1392256 - Hyphenation libraries aren't package dependent of build locale, let's stop pretending

Status: RESOLVED FIXED

(Core :: Internationalization, enhancement, P3)

Description

[Axel Hecht [:Pike]]

When we added hyphenation support, we had that academic idea that we'd ship different hyphenation dictionaries depending on UI locale.

We don't, though, and that's probably good that way.

We do ship none at all on platforms where we're worried about the download size, though.

Anywho, we're just wasting time with the hyphenation part, and adding complexity here compared to other dirs, where we just process jar.mn.

Let's rip this out.

Filing under intl, as that's where the code is, and probably also the ownership of hyphenation. It's as much a build config bug, though.

CCing Tom, Philipp, JorgK as comm-central will want to do the same.

Comment 1

[Axel Hecht [:Pike]]

Attachment: bug 1392256, hyphenation dicts don't depend on locale, drop from repacks,

The hyphenation dictionaries we ship as part of the build don't depend
on the UI locale, let's stop treating them as localizable content during
repacks.

Review commit: https://reviewboard.mozilla.org/r/170742/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170742/

Comment 2

[Axel Hecht [:Pike]]

Pushed this to try, https://treeherder.mozilla.org/#/jobs?repo=try&revision=bfefa8f5878911b6db5771cc29d4127d0c902cca

Comment 3

[Zibi Braniecki [:zbraniecki][:gandalf]]

CC'ing Jonathan, since he's been working on hypenations not long ago.

General question - are we using hypenation directories for the UI locale only? If so, would it make sense to get them as part of the langpack in the multi-locale build (not part of this bug, just asking here)?

Comment 4

[Axel Hecht [:Pike]]

Hyphenation dictionaries are used for line breaking in web content, that's why we're shipping them regardless of UI locale

Comment 5

[Jonathan Kew [:jfkthame]]

(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #3)
> General question - are we using hypenation directories for the UI locale
> only?

No, we use hyphenation dicts (if available) for whatever language(s) are specified in web content with the lang attribute (along with the hyphens:auto property). And we don't want the collection of available hyph dicts to depend on the UI locale or the locale of the Firefox build, neither of which constrain the languages that may occur in content.

Comment 6

[Axel Hecht [:Pike]]

Try is pretty green, though it doesn't do any actual tests on the localized builds. I tested macs locally, and linux64 by downloading the localized try builds, and both have the hyphenation dicts in the top-level omni.ja, as expected.

Comment 7

[Makoto Kato [:m_kato]]

Comment on attachment 8899457 [details]
bug 1392256, hyphenation dicts don't depend on locale, drop from repacks,

https://reviewboard.mozilla.org/r/170742/#review176162

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8899457 [details]
bug 1392256, hyphenation dicts don't depend on locale, drop from repacks,

https://reviewboard.mozilla.org/r/170742/#review177058

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c423d7c2998a
hyphenation dicts don't depend on locale, drop from repacks, r=gps,m_kato

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c423d7c2998a

Comment 11

[Jorg K (CEST = GMT+2)]

(In reply to Axel Hecht [:Pike] from comment #0)
> CCing Tom, Philipp, JorgK as comm-central will want to do the same.

OK, I'm coming to this a little late:
So you removed
- @$(MAKE) -C ../../intl/locales AB_CD=$* XPI_NAME=locale-$*
- @$(MAKE) -C ../../intl/locales chrome AB_CD=$*

I have no idea what effect that has, but we have the first line here in TB/IB and SM:
https://dxr.mozilla.org/comm-central/search?q=intl%2Flocales+AB_CD%3D%24*+XPI_NAME%3Dlocale&redirect=false

So we want to remove those three lines?

Can you please explain.

Comment 12

[Axel Hecht [:Pike]]

(In reply to Jorg K (GMT+2) from comment #11)
> (In reply to Axel Hecht [:Pike] from comment #0)
> > CCing Tom, Philipp, JorgK as comm-central will want to do the same.
> 
> OK, I'm coming to this a little late:
> So you removed
> - @$(MAKE) -C ../../intl/locales AB_CD=$* XPI_NAME=locale-$*
> - @$(MAKE) -C ../../intl/locales chrome AB_CD=$*
> 
> I have no idea what effect that has, but we have the first line here in
> TB/IB and SM:
> https://dxr.mozilla.org/comm-central/
> search?q=intl%2Flocales+AB_CD%3D%24*+XPI_NAME%3Dlocale&redirect=false
> 
> So we want to remove those three lines?

Right.