Closed Bug 1392256 Opened 2 years ago Closed 2 years ago

Hyphenation libraries aren't package dependent of build locale, let's stop pretending

Categories

(Core :: Internationalization, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: Pike, Assigned: Pike)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

When we added hyphenation support, we had that academic idea that we'd ship different hyphenation dictionaries depending on UI locale.

We don't, though, and that's probably good that way.

We do ship none at all on platforms where we're worried about the download size, though.

Anywho, we're just wasting time with the hyphenation part, and adding complexity here compared to other dirs, where we just process jar.mn.

Let's rip this out.

Filing under intl, as that's where the code is, and probably also the ownership of hyphenation. It's as much a build config bug, though.

CCing Tom, Philipp, JorgK as comm-central will want to do the same.
Assignee: nobody → l10n
CC'ing Jonathan, since he's been working on hypenations not long ago.

General question - are we using hypenation directories for the UI locale only? If so, would it make sense to get them as part of the langpack in the multi-locale build (not part of this bug, just asking here)?
Hyphenation dictionaries are used for line breaking in web content, that's why we're shipping them regardless of UI locale
(In reply to Zibi Braniecki [:gandalf][:zibi] from comment #3)
> General question - are we using hypenation directories for the UI locale
> only?

No, we use hyphenation dicts (if available) for whatever language(s) are specified in web content with the lang attribute (along with the hyphens:auto property). And we don't want the collection of available hyph dicts to depend on the UI locale or the locale of the Firefox build, neither of which constrain the languages that may occur in content.
Try is pretty green, though it doesn't do any actual tests on the localized builds. I tested macs locally, and linux64 by downloading the localized try builds, and both have the hyphenation dicts in the top-level omni.ja, as expected.
Comment on attachment 8899457 [details]
bug 1392256, hyphenation dicts don't depend on locale, drop from repacks,

https://reviewboard.mozilla.org/r/170742/#review176162
Attachment #8899457 - Flags: review?(m_kato) → review+
Comment on attachment 8899457 [details]
bug 1392256, hyphenation dicts don't depend on locale, drop from repacks,

https://reviewboard.mozilla.org/r/170742/#review177058
Attachment #8899457 - Flags: review?(gps) → review+
Priority: -- → P3
Pushed by axel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c423d7c2998a
hyphenation dicts don't depend on locale, drop from repacks, r=gps,m_kato
https://hg.mozilla.org/mozilla-central/rev/c423d7c2998a
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
(In reply to Axel Hecht [:Pike] from comment #0)
> CCing Tom, Philipp, JorgK as comm-central will want to do the same.

OK, I'm coming to this a little late:
So you removed
- @$(MAKE) -C ../../intl/locales AB_CD=$* XPI_NAME=locale-$*
- @$(MAKE) -C ../../intl/locales chrome AB_CD=$*

I have no idea what effect that has, but we have the first line here in TB/IB and SM:
https://dxr.mozilla.org/comm-central/search?q=intl%2Flocales+AB_CD%3D%24*+XPI_NAME%3Dlocale&redirect=false

So we want to remove those three lines?

Can you please explain.
Flags: needinfo?(l10n)
Flags: needinfo?(gandalf)
(In reply to Jorg K (GMT+2) from comment #11)
> (In reply to Axel Hecht [:Pike] from comment #0)
> > CCing Tom, Philipp, JorgK as comm-central will want to do the same.
> 
> OK, I'm coming to this a little late:
> So you removed
> - @$(MAKE) -C ../../intl/locales AB_CD=$* XPI_NAME=locale-$*
> - @$(MAKE) -C ../../intl/locales chrome AB_CD=$*
> 
> I have no idea what effect that has, but we have the first line here in
> TB/IB and SM:
> https://dxr.mozilla.org/comm-central/
> search?q=intl%2Flocales+AB_CD%3D%24*+XPI_NAME%3Dlocale&redirect=false
> 
> So we want to remove those three lines?

Right.
Flags: needinfo?(l10n)
Flags: needinfo?(gandalf)
You need to log in before you can comment on or make changes to this bug.