Closed Bug 1392295 Opened 2 years ago Closed 2 years ago

Hide Images feature: use content blocker

Categories

(Firefox for iOS :: General, enhancement, P3)

Other
iOS
enhancement

Tracking

()

RESOLVED FIXED
Iteration:
1.30
Tracking Status
fxios 10.0 ---

People

(Reporter: garvan, Assigned: garvan)

Details

(Whiteboard: [MobileCore])

Attachments

(1 file)

55 bytes, text/x-github-pull-request
justindarc
: review+
Details | Review
We can now implement a hide images feature that blocks network loads of images.

I just hooked this up to try it out, looks great so far. 
Quick code snippet for later use in ContentBlockerHellper.swift:

        let json = "[{'trigger':{'url-filter':'.*','resource-type':['image']},'action':{'type':'block'}}]".replacingOccurrences(of: "'", with:"\"")
        self.ruleStore.compileContentRuleList(forIdentifier: "images", encodedContentRuleList: json) {
            rule, error in
            self.addToTab(contentRuleList: rule, error: error)
        }
tracking-fxios: --- → ?
Priority: -- → P2
See this PR that adds option to enable only when offline
https://github.com/mozilla-mobile/firefox-ios/pull/2806
not offline, I mean't to say off-wifi / on-cell-data.
Whiteboard: [MobileCore]
Priority: P2 → P3
Attached file Pull request
Attachment #8908628 - Flags: review?(jdarcangelo)
Iteration: --- → 1.30
Assignee: nobody → gkeeley
Attachment #8908628 - Flags: review?(jdarcangelo) → review+
on master and 10.x
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.