1392303 - iOS 11: Bookmarks swipe-delete enabled on all items (not root-only)

Status: VERIFIED FIXED

(Firefox for iOS :: Data Storage, defect, P2)

Description

[:garvan]

Deleting bookmarks in the table view should only be enabled in the root view.
On iOS 11, I can swipe on any item, in any subfolder also, and get delete mode.

Comment 1

[:garvan]

Confirmed this is swipe-delete only behaviour, long-press context menu doesn't offer deletion.

Comment 2

[:garvan]

Not fixed in beta 6. 

Filed apple bug 34006800

---------------------------------
Summary:
Returning a delete action from editActionsForRowAt  and a .none style for editingStyleForRowAt, the row will be incorrectly deletable. iOS 8,9,10 did not have this behaviour.

Steps to Reproduce:
Implement both functions:
override func tableView(_ tableView: UITableView, editActionsForRowAt indexPath: IndexPath) -> [UITableViewRowAction]? {
override func tableView(_ tableView: UITableView, editingStyleForRowAt indexPath: IndexPath) -> UITableViewCellEditingStyle 

Returning a delete action from editActionsForRowAt  and a .none style for editingStyleForRowAt.

Expected Results:
As per previous iOS, the editingStyleForRowAt returning .none should result in no delete action shown when swiping on a cell.

Observed Results:
Can swipe delete to show edit button on rows.

Version:
iOS 11 xcode9 beta 5

Notes:
Quick repro: create a project in xcode of master-detail view controller type, and paste this code into MasterViewController.swift

override func tableView(_ tableView: UITableView, editActionsForRowAt indexPath: IndexPath) -> [UITableViewRowAction]? {
        let delete = UITableViewRowAction(style: UITableViewRowActionStyle.default, title: "Delete", handler: { (action, indexPath) in
        })
        return [delete]
}

override func tableView(_ tableView: UITableView, editingStyleForRowAt indexPath: IndexPath) -> UITableViewCellEditingStyle {
        return .none
}

Run the project and swipe delete on a cell. The '.none' type of editing style is ignored, and swipe shows the delete button on a cell.

Comment 3

[Richard Newman [:rnewman]]

Drop it in http://openradar.appspot.com/, Garvan?

Comment 4

[:garvan]

it is now very close to the release date for iOS 11, so I am pushing up a fix in for this in bit. I'll still file on openradar just so others are aware the API behaviour has changed.

Comment 5

[:garvan]

Attachment: Pull request

Comment 6

[:garvan]

landed: https://github.com/mozilla-mobile/firefox-ios/commit/dfc68f90dadf782fc947ece7d9ef1e4aea0df300
uplifted to 9.x

Comment 7

[:garvan]

http://www.openradar.me/radar?id=5542995990413312

Comment 8

[Catalin Suciu [:csuciu]]

On latest v8.x and v9.x builds, I'm no longer able to swipe-to-delete bookmarks inside the "Desktop Bookmarks" folder