Closed Bug 1392317 Opened 7 years ago Closed 7 years ago

Tracking Protection description is cut off on iPad

Categories

(Firefox for iOS :: General, defect)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Iteration:
1.29
Tracking Flags:
Tracking Status
fxios 9.0 ---

People

(Reporter: aaronmt, Assigned: garvan)

Details

(Whiteboard: [MobileCore])

Attachments

(2 files, 1 obsolete file)

Screen Shot 2017-08-21 at 12.31.15 PM.png
324.73 KB, image/png
Details
Pull request
55 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review 
See screenshot.
Assignee: nobody → gkeeley
Attached file Pull request (obsolete) — 

        Attachment #8899606 -
        Flags: review?(jhugman)

    
    

    
  
Note to me: don't forget to uplift to 9.x

          tracking-fxios:
          ? → 9.0
Whiteboard: [needsuplift]

        Attachment #8899606 -
        Flags: review?(jhugman) → review+

    
    

    
  
Reverting the 9.x landing: ddbe0ac1bf146293a3cf80c3c992ef8078f788e6
I am re-opening this bug as the spacing changes here changed spacing in other settings.
I need to more carefully check this on a variety of screen sizes, and check the non-TP settings to make sure they look correct.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
  
Iteration: --- → 1.29

    
    

    
  

      
      
      
      

        Attached file
          
        Pull request
        — 
      

    


  
James I finally found the magic incantation to get this footer view to resize automatically without having to try use estimated text bounds (which returns an under-estimated size according to apple api docs).

        Attachment #8899606 -
        Attachment is obsolete: true

        Attachment #8900089 -
        Flags: review?(jhugman)

    
    

    
  
Comment on attachment 8900089 [details] [review]
Pull request

Looks good

        Attachment #8900089 -
        Flags: review?(jhugman) → review+

    
    

    
  
landed on master and on 9.x https://github.com/mozilla-mobile/firefox-ios/pull/3087
Status: REOPENED → RESOLVED
Closed: 7 years ago → 7 years ago
Resolution: --- → FIXED
Whiteboard: [needsuplift]

    
    

    
  
Verified as fixed on latest master and v9.0(5607)
Status: RESOLVED → VERIFIED
Whiteboard: [MobileCore]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: