Closed Bug 1392351 Opened 7 years ago Closed 7 years ago

Focus Install Event Not Firing

Categories

(Firefox for iOS :: Telemetry, enhancement)

Other
iOS
enhancement
Not set
normal

Tracking

()

VERIFIED FIXED
Tracking Status
fxios 8.3 ---
fxios-v8.3 --- verified
fxios-v10.0 --- verified

People

(Reporter: sdaswani, Assigned: bmunar)

Details

(Whiteboard: [mma] [MobileCore])

Attachments

(1 file)

55 bytes, text/x-github-pull-request
st3fan
: review+
Details | Review
I installed firefox without focus installed. Then I installed focus. I didn't see the focus installed event fire. Please check what is going on and also check the pocket logic as it's exactly the same.
Assignee: nobody → bmunar
Whiteboard: [mma] [MobileCore][needsuplift]
You should move the tracking calls immediately preceding to a block which you supply to this method: https://www.leanplum.com/dashboard/static/iosdocs/html/interface_leanplum.html#a8066dfaad2b13bf0b3eda3b4bee37074
Attached file PR
Attachment #8899718 - Flags: review?(sarentz)
Comment on attachment 8899718 [details] [review] PR See comments in the PR.
Attachment #8899718 - Flags: review?(sarentz) → review-
Comment on attachment 8899718 [details] [review] PR r+ after justin's comments
Attachment #8899718 - Flags: review- → review+
Landed on master, uplifted to v8.x and v9.x
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [mma] [MobileCore][needsuplift] → [mma] [MobileCore]
Verifying as fix on master 9baa97bb22b.
Verifying as fix on beta 8.3(5817).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: