1392470 - Add wr support for nsDisplayButtonBoxShadowOuter

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

The implementation should be similar to nsDisplayBoxShadowOuter.

Comment 1

[Kevin Chen[:kechen] (UTC + 8)]

Attachment: Bug 1392470 - Add wr support for nsDisplayButtonBoxShadowOuter;

Review commit: https://reviewboard.mozilla.org/r/172500/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172500/

Comment 2

[Kevin Chen[:kechen] (UTC + 8)]

Comment on attachment 8901036 [details]
Bug 1392470 - Add wr support for nsDisplayButtonBoxShadowOuter;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172500/diff/1-2/

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8901036 [details]
Bug 1392470 - Add wr support for nsDisplayButtonBoxShadowOuter;

https://reviewboard.mozilla.org/r/172500/#review178322

::: layout/forms/nsButtonFrameRenderer.cpp:195
(Diff revision 2)
> +    mozilla::gfx::RectCornerRadii borderRadii;
> +    hasBorderRadius = nsCSSRendering::GetBorderRadii(shadowRect,
> +                                                     shadowRect,
> +                                                     mFrame,
> +                                                     borderRadii);
> +    // TODO: support non-uniform border radius.

Shouldn't we return false/LAYER_NONE for the case where the border radius isn't uniform?

Or are we ok with just rendering wrong until this gets fixed?

Comment 4

[Kevin Chen[:kechen] (UTC + 8)]

Comment on attachment 8901036 [details]
Bug 1392470 - Add wr support for nsDisplayButtonBoxShadowOuter;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172500/diff/2-3/

Comment 5

[Kevin Chen[:kechen] (UTC + 8)]

(In reply to Matt Woodrow (:mattwoodrow) from comment #3)
> Comment on attachment 8901036 [details]
> Bug 1392470 - Add wr support for nsDisplayButtonBoxShadowOuter;
> 
> https://reviewboard.mozilla.org/r/172500/#review178322
> 
> ::: layout/forms/nsButtonFrameRenderer.cpp:195
> (Diff revision 2)
> > +    mozilla::gfx::RectCornerRadii borderRadii;
> > +    hasBorderRadius = nsCSSRendering::GetBorderRadii(shadowRect,
> > +                                                     shadowRect,
> > +                                                     mFrame,
> > +                                                     borderRadii);
> > +    // TODO: support non-uniform border radius.
> 
> Shouldn't we return false/LAYER_NONE for the case where the border radius
> isn't uniform?
> 
> Or are we ok with just rendering wrong until this gets fixed?

Yes, we haven't support non-uniform border radius in web render, Ethan is working on this in Bug 1393383.
The latest patch will return LAYER_NONE in nsDisplayButtonBoxShadowOuter::GetLayerState.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aee7b8d6a886
Add wr support for nsDisplayButtonBoxShadowOuter; r=mattwoodrow

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/aee7b8d6a886