1392549 - nsIRollupListener::Rollup expects mouse pointer position in device pixels

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement)

Description

[Jessica Jong [:jessica] (inactive)]

See this piece of code [1], widget code should pass mouse poisition in device pixels.

This bug can be revealed by using the search box in the upper right corner of the browser. Type any word, e.g. "test", until a list of suggestion shows up, clicking any other part in the search input box should not cause the panel (list of suggestion) to hide (and show again).


[1] http://searchfox.org/mozilla-central/rev/48ea452803907f2575d81021e8678634e8067fc2/layout/xul/nsXULPopupManager.cpp#301-302

Comment 1

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 2

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8899761 [details] [diff] [review]
patch, v1.

Hi Markus, can I have your review on this? Thanks.

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8899761 [details] [diff] [review]
patch, v1.

Review of attachment 8899761 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsChildView.mm
@@ +4210,5 @@
>            NSPoint point = [NSEvent mouseLocation];
>            FlipCocoaScreenCoordinate(point);
> +          LayoutDeviceIntPoint devPoint =
> +            mGeckoChild->CocoaPointsToDevPixels(point);
> +          gfx::IntPoint pos = gfx::IntPoint::Truncate(devPoint.x, devPoint.y);

devPoint already has integer components here, so you don't need Truncate. I think devPoint.ToUnknown() will give you an IntPoint.

Comment 4

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v2.

Use .ToUnknownPoint() to get IntPoint.

Thanks Markus.

Comment 5

[Jessica Jong [:jessica] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=def5c7558092178cfea647adc09420cff8c55d46&group_state=expanded

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/143df4bd4a59
Pass mouse position to nsIRollupListener::Rollup in device pixels. r=mstange

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/143df4bd4a59