1392594 - Warning as Error in MinGW build: unusued variable in VolatileBufferWindows.cpp

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1392594 Make variable DebugOnly to address unused variable warning

Review commit: https://reviewboard.mozilla.org/r/171136/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171136/

Comment 2

[Tom Ritter [:tjr]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0d9512065679122562720a278afd277a51c731f

Comment 3

[Tom Ritter [:tjr]]

Actually we need an opt try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=33c8bc8343e019eafd5988233fec6c18fa69a218

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8899811 [details]
Bug 1392594 Make variable DebugOnly to address unused variable warning

https://reviewboard.mozilla.org/r/171136/#review177702

::: memory/volatile/VolatileBufferWindows.cpp:124
(Diff revision 1)
>                                mBuf,
>                                mSize,
>                                MEM_RESET,
>                                PAGE_READWRITE);

Please realign.

Comment 5

[Tom Ritter [:tjr]]

Comment on attachment 8899811 [details]
Bug 1392594 Make variable DebugOnly to address unused variable warning

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171136/diff/1-2/

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8899811 [details]
Bug 1392594 Make variable DebugOnly to address unused variable warning

https://reviewboard.mozilla.org/r/171136/#review177756

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a8e0f1bade08
Make variable DebugOnly to address unused variable warning r=glandium

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/a8e0f1bade08