1392641 - netwerk/ ignores return values from a functions declared with warn_unused_result

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Tom Ritter [:tjr]]

/home/worker/workspace/build/src/netwerk/base/BackgroundFileSaver.cpp:911:40: error: ignoring return value of function declared with attribute warn_unused_result [-Werror=unused-result]
             nssCertList->AddCert(nssCert);

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1392641 Check return value for functions declared with warn_unused_result

Review commit: https://reviewboard.mozilla.org/r/171208/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171208/

Comment 2

[Tom Ritter [:tjr]]

Try run:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=d64948eba852a8f378fcf35bb60337565cab607e

Comment 3

[Tom Ritter [:tjr]]

Comment on attachment 8899874 [details]
Bug 1392641 Check return value for functions declared with warn_unused_result

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171208/diff/1-2/

Comment 4

[Daniel Stenberg [:bagder]]

Comment on attachment 8899874 [details]
Bug 1392641 Check return value for functions declared with warn_unused_result

https://reviewboard.mozilla.org/r/171208/#review177904

::: netwerk/system/win32/nsNotifyAddrListener.cpp:217
(Diff revision 2)
>                      sha1.update(combined.get(), combined.Length());
>                      uint8_t digest[SHA1Sum::kHashSize];
>                      sha1.finish(digest);
>                      nsCString newString(reinterpret_cast<char*>(digest),
>                                          SHA1Sum::kHashSize);
> -                    Base64Encode(newString, output);
> +                    rv = Base64Encode(newString, output);

I think you should move the 'rv' declaration to happen just before this (only) use of it. We tend to try to keep the declarations close to the users.

Comment 5

[Daniel Stenberg [:bagder]]

Comment on attachment 8899874 [details]
Bug 1392641 Check return value for functions declared with warn_unused_result

https://reviewboard.mozilla.org/r/171208/#review177906

Just one minor comment.

Comment 6

[Tom Ritter [:tjr]]

Comment on attachment 8899874 [details]
Bug 1392641 Check return value for functions declared with warn_unused_result

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171208/diff/2-3/

Comment 7

[Tom Ritter [:tjr]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cca79dcde65a4a5643ef26d31ecee9f403e9bba9

Comment 8

[u408661]

Comment on attachment 8899874 [details]
Bug 1392641 Check return value for functions declared with warn_unused_result

https://reviewboard.mozilla.org/r/171208/#review178170

::: netwerk/system/win32/nsNotifyAddrListener.cpp:217
(Diff revision 3)
>                      uint8_t digest[SHA1Sum::kHashSize];
>                      sha1.finish(digest);
>                      nsCString newString(reinterpret_cast<char*>(digest),
>                                          SHA1Sum::kHashSize);
> -                    Base64Encode(newString, output);
> +                    nsresult rv;
> +                    rv = Base64Encode(newString, output);

(nit): nsresult rv = Base64Encode...

Comment 9

[Tom Ritter [:tjr]]

Comment on attachment 8899874 [details]
Bug 1392641 Check return value for functions declared with warn_unused_result

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171208/diff/3-4/

Comment 10

[u408661]

Comment on attachment 8899874 [details]
Bug 1392641 Check return value for functions declared with warn_unused_result

https://reviewboard.mozilla.org/r/171208/#review178174

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/56ae3de7d69c
Check return value for functions declared with warn_unused_result r=bagder,nwgh

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/56ae3de7d69c