1392673 - Black flicker/blink/flash before drop down menu rendering after landing patch from bug #1382680

Status: VERIFIED WORKSFORME

(Core :: Graphics, defect, P3)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

STR:
1. Open drop down menu with mouse button
and enjoy black flicker/blink/flash before drop down menu rendering.

If you can't reproduce it first time,
just spammy press mouse button multiple times to reproduce it instantaneously.


Regression range pushlog:
https://hg.mozilla.org/integration/autoland/json-pushes?changeset=62ab9018744dbf57f811ee26fac14542be5e02ee&full=1


Caused by:
Bug #1382680 - Only add extended style WS_EX_COMPOSITED when using OMTC, r=bas,jimm

Comment 1

[Peter Chang[:pchang]]

I can't reproduce this on my windows 7 machine. Reporter, could you attach the video when the problem happened?

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: screencast.mp4

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Graphics section from about:support.txt

Unfortunately, the issue, which is this black flicker/blink/flash is not seen on attached screencast.

STR:
1. Open this URL - http://forums.mozillazine.org/viewforum.php?f=23
2. Open drop down menu with mouse button
and enjoy black flicker/blink/flash before drop down menu rendering.

I'm attaching also Graphics section from about:support (WebGL is disabled manually).

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Per bug #1382680 comment #31, I'm marking Firefox 56 as also affected.

Comment 5

[Peter Chang[:pchang]]

Reporter, I can't see the black flicker from attachment 8900164 [details] and I only saw the menu keeping disappear/appear. I think it is normal to see pop up menu disappear/appear when you click the mouse button in different place in old or current nightly.

And I can't reproduce the black flicker from comment 3. Can you attach the video about the good behavior?

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Peter Chang[:pchang] from comment #5)
> Reporter, I can't see the black flicker from attachment 8900164 [details]
> and I only saw the menu keeping disappear/appear.

I wrote that, unfortunately it's not visible on screencast,
see:
(In reply to Virtual_ManPL [:Virtual] from comment #3)
> Unfortunately, the issue, which is this black flicker/blink/flash is not
> seen on attached screencast.



(In reply to Peter Chang[:pchang] from comment #5)
> And I can't reproduce the black flicker from comment 3. Can you attach the
> video about the good behavior?

I will record screencast with phone camera at 120FPS, so it will be probably visible.

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

> (In reply to Peter Chang[:pchang] from comment #5)
> > And I can't reproduce the black flicker from comment 3. Can you attach the
> > video about the good behavior?
> 
> I will record screencast with phone camera at 120FPS, so it will be probably
> visible.

Done, see it under this URL - https://a.pomfe.co/mwebexk.mp4
It's reproducible in about 25% in all drop down menu renderings.

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

Comment 9

[Peter Chang[:pchang]]

I still couldn't reproduce this in another window 7 machines (nv 630). Reporter, are you able to reproduce this in another windows 7 environment? It might be related to hardware.

Comment 10

[Gerry Chang [:gchang]]

This seems to be an edge case behavior. Track 56- and mark 56 as fix-optional. Feel free to nominate again if you don't disagree.

Comment 11

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

(In reply to Peter Chang[:pchang] from comment #9)
> I still couldn't reproduce this in another window 7 machines (nv 630).
> Reporter, are you able to reproduce this in another windows 7 environment?
> It might be related to hardware.

I will try and report back with results.

Edge case to very fast reproducing this issue is:
STR:
1. Enable "Menu Bar"
2. Press "File" option to open File menu
3. Move mouse cursor/pointer right and left between "Help" option and "File" option.



@ Alice0775 White - As senior bugmaster, are you able to reproduce this issue on Windows 7?

Comment 12

[Alice0775 White]

My Win7 is on VM and HWA is not available. So, I cannot test this.

Comment 13

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

It happening also here in Safe Mode without HW.

Comment 14

[Alice0775 White]

It may need the following information.
Windows System Theme, 
Information of "Performance of Visual Effects"

Comment 15

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

In my case, I'm using default "Windows 7" Aero composition (only window color was changed to black) and "Performance of Visual Effects" is set to "Custom:" with all options marked/checked/enabled.

Comment 16

[Julien Cristau [:jcristau]]

See comment 10.

Comment 17

[Milan Sreckovic [:milan] (needinfo for best results)]

Peter, can we get a try build with bug 1382680 patches backed out to confirm the regression range?  Then we could perhaps get :Virtual to run it and verify.

Comment 18

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

FYI - I was running mozregression GUI and it specified that it was caused by bug #1382680, see pushlog from comment #0. But I can resest by double checking it in new build to make sure, that it's really caused by it.

Comment 19

[Peter Chang[:pchang]]

Reporter, I made some changes with the latest master(not backed out bug 1382680). Could you try to reproduce the problem with the following try build? Thanks.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=880b0cc739bc58e0aa56b5900574353657b255ce

Comment 20

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Hmm, seems I didn't used Treeharder for very long time, as I can't find URL with download ZIP file.
Is it this "target.zip" in "Job Details" tab, when I'm pressing "B" on "Windows 2012 x64 opt"?
I remember that it had proper name, not some odd one, like now.

Comment 21

[Peter Chang[:pchang]]

After clicking one build task, you can search for "artifact uploaded: target.zip" and download the target.zip.

Comment 22

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I can still reproduce issue with this build (rev: 880b0cc739bc58e0aa56b5900574353657b255ce).

Comment 23

[Milan Sreckovic [:milan] (needinfo for best results)]

Comment 22 would suggest our regression range is not quite right

Comment 24

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Regression range is proper (double-checked now) and patches from bug #1382680 wasn't completely backed out in test build provided in Comment 19.
>(Peter Chang[:pchang] wrote in comment #19)
>> [...]I made some changes with the latest master(not backed out bug 1382680)

Comment 25

[Liz Henry (:lizzard) (relman/hg->git project)]

A note of explanation. fThis is something of an edge case, not a broad impact on many users, we can't reproduce it, it's from a regression over a year ago, and isn't going to be a priority for the graphics team. Unless we started seeing many more reports of this or the problem gets worse, this is marked "fix-optional" and gfx-noted.  Marking it fix-optional means it will not be included in the weekly regression engineering triage sessions. 

That basically means we'd take a patch, but we don't want to keep re-triaging the bug.

Comment 26

[Neha Kochar [:neha]]

Bulk change for all regression bugs with status-firefox67 as 'fix-optional' to be marked 'affected' for status-firefox68.

Comment 27

[Tim Spurway [:tspurway]]

[bulk change 69 status -> --- b/c to stop re-triaging old regressions every release]

Triage Owners: please do not set release status tracking flags in new releases unless this bug will actually be worked on

Comment 28

[Alin Ilea, Desktop Test Engineering]

Hi,

I have tested your issue on latest Nightly build 96.0a1 (2021-11-16) and could not reproduce it using Windows 7.
If the issue is still reproducible on your end, can you please retest this using latest Nightly build (https://nightly.mozilla.org/) and report back the results? Otherwise, given the fact that there are no new updates, this ticket might be closed.

Thanks.

Comment 29

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that the bug cannot be longer reproduced in Mozilla Firefox Nightly 97.0a1 (2021-12-20), so I'm marking this bug as WORKSFORME.