1392677 - Unused function warning for mozilla::ReportException(EXCEPTION_POINTERS*) (false positive)

Status: RESOLVED DUPLICATE of bug 1393222

(Core :: XPCOM, enhancement)

Comment 1

[Tom Ritter [:tjr]]

Attachment: Bug 1392677: Silence unused-function warning

nsCrashOnException.cpp:18:1: error: 'int mozilla::ReportException(EXCEPTION_POINTERS*)' defined but not used [-Werror=unused-function]

I promise you it is called, you just can't figure out where.

Review commit: https://reviewboard.mozilla.org/r/171226/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171226/

Comment 2

[Tom Ritter [:tjr]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5478e6cce3deaa3c5c7269a817fedd1af4d8047

Comment 3

[Nathan Froyd [:froydnj]]

Comment on attachment 8899895 [details]
Bug 1392677: Silence unused-function warning

https://reviewboard.mozilla.org/r/171226/#review176382

r=me with the following changes:

::: xpcom/base/moz.build:187
(Diff revision 1)
> +if CONFIG['GNU_CXX']:
> +    CXXFLAGS += ['-Wno-unused-function']

This condition should live...

::: xpcom/base/moz.build:194
(Diff revision 1)
>  elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows':
>      SOURCES += [
>          'nsCrashOnException.cpp',
>      ]

...in this branch, so we're only disabling the warning on windows and with `GNU_CXX`.

Comment 4

[Tom Ritter [:tjr]]

Comment on attachment 8899895 [details]
Bug 1392677: Silence unused-function warning

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171226/diff/1-2/