Closed
Bug 1392677
Opened 7 years ago
Closed 7 years ago
Unused function warning for mozilla::ReportException(EXCEPTION_POINTERS*) (false positive)
Categories
(Core :: XPCOM, enhancement)
Core
XPCOM
Tracking
()
RESOLVED
DUPLICATE
of bug 1393222
People
(Reporter: tjr, Assigned: tjr)
References
Details
(Whiteboard: [tor])
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8899895 -
Flags: review?(nfroyd)
Assignee | ||
Comment 2•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c5478e6cce3deaa3c5c7269a817fedd1af4d8047
![]() |
||
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8899895 [details] Bug 1392677: Silence unused-function warning https://reviewboard.mozilla.org/r/171226/#review176382 r=me with the following changes: ::: xpcom/base/moz.build:187 (Diff revision 1) > +if CONFIG['GNU_CXX']: > + CXXFLAGS += ['-Wno-unused-function'] This condition should live... ::: xpcom/base/moz.build:194 (Diff revision 1) > elif CONFIG['MOZ_WIDGET_TOOLKIT'] == 'windows': > SOURCES += [ > 'nsCrashOnException.cpp', > ] ...in this branch, so we're only disabling the warning on windows and with `GNU_CXX`.
Attachment #8899895 -
Flags: review?(nfroyd) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•