Closed Bug 1392710 Opened 5 years ago Closed 4 years ago

Add use counters for marquee events

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ayg, Assigned: jkt)

References

Details

Attachments

(2 files, 1 obsolete file)

Chrome/WebKit do not appear to implement marquee events (start, bounce, finish) at all:

https://bugs.chromium.org/p/chromium/issues/detail?id=522326

So perhaps we can drop support.  Unfortunately, <marquee> is written in XBL, so I'm not sure how to do use counters.
Comment on attachment 8899947 [details]
Bug 1392710 - Add use counters for marquee events;

https://reviewboard.mozilla.org/r/171278/#review176428
Attachment #8899947 - Flags: review?(bugs) → review+
Comment on attachment 8899947 [details]
Bug 1392710 - Add use counters for marquee events;

https://reviewboard.mozilla.org/r/171278/#review176434

datareview+
Attachment #8899947 - Flags: review?(francois) → review+
Assignee: nobody → ayg
Status: NEW → ASSIGNED
Priority: -- → P2
Priority: P2 → P3
I rebased the patch and moved the atom declaration, I double checked that this collects events in about:telemetry;

1. load:
data:text/html,<body bgcolor="whyisthisacolour?"><marquee id=m loop=1 scrollamount=90 onstart="a"><iframe src="https://giphy.com/gifs/iN1aMj0XwhsNq/html5" height=500 width=500 scrolling=no></iframe><script>["start", "bounce", "finish"].forEach(e => { m.addEventListener(e, (...args) => {console.log({[e]: args})}); }); m.stop()</script>
2. open about:telemetry
3. click histograms
4. select "content"
5. filter "counter2"

Does this need anything else to land?
Assignee: ayg → jkt
Flags: needinfo?(francois)
Flags: needinfo?(bugs)
Attachment #8899947 - Attachment is obsolete: true
Blocks: 1314567
Would you mind filling out the data review request form (https://github.com/mozilla/data-review/blob/master/request.md) and attaching it as a .txt so that you can r? me on it?

It should be pretty straightforward since you already have a clear question you want answered (are there a lot of websites using these).
Flags: needinfo?(francois)
Attachment #8993365 - Flags: review?(francois)
Looks reasonable
Flags: needinfo?(bugs)
Would you be able to r+ on phabricator so I can land this? https://phabricator.services.mozilla.com/D2209

Thanks
Flags: needinfo?(bugs)
Comment on attachment 8992796 [details]
Bug 1392710 - Add use counters for marquee events.

Olli Pettay [:smaug] (vacation Jul 15->) has approved the revision.

https://phabricator.services.mozilla.com/D2209
Attachment #8992796 - Flags: review+
Comment on attachment 8993365 [details]
marquee-events-data-review.md

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Jonathan Kingston.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.
Attachment #8993365 - Flags: review?(francois) → review+
BTW, if you rename the form to .txt, it's easier to review since it gets displayed inline in Bugzilla.
Pushed by jkingston@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/873b3e2c3d2b
Add use counters for marquee events. r=smaug
https://hg.mozilla.org/mozilla-central/rev/873b3e2c3d2b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Flags: needinfo?(bugs)
You need to log in before you can comment on or make changes to this bug.