1392745 - Keep MID in disabled m-sections

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, enhancement, P2)

Description

[Nils Ohlmeier [:drno]]

It makes sense to maintain the MID's in m-section when we disable them, so that the offerer can still use the MID to figure out which m-section we disabled.

Comment 1

[Nils Ohlmeier [:drno]]

Attachment: Bug 1392745: keep MID when disabling m-sections

Review commit: https://reviewboard.mozilla.org/r/171298/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171298/

Comment 2

[Nils Ohlmeier [:drno]]

Attachment: Bug 1392745: verify mid presence in inactive m-section

Review commit: https://reviewboard.mozilla.org/r/171300/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171300/

Comment 3

[Michael Froman [:mjf]]

Comment on attachment 8899984 [details]
Bug 1392745: keep MID when disabling m-sections

https://reviewboard.mozilla.org/r/171298/#review176944

Looks good to me.

Comment 4

[Michael Froman [:mjf]]

Comment on attachment 8899985 [details]
Bug 1392745: verify mid presence in inactive m-section

https://reviewboard.mozilla.org/r/171300/#review176950

Looks good to me.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ce80881b78c
keep MID when disabling m-sections r=mjf
https://hg.mozilla.org/integration/autoland/rev/58633245c138
verify mid presence in inactive m-section r=mjf

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5ce80881b78c
https://hg.mozilla.org/mozilla-central/rev/58633245c138