Closed Bug 1392761 Opened 3 years ago Closed 2 years ago
Pull Down in Bookmarks to Trigger a Bookmark Sync Refresh
55 bytes, text/x-github-pull-request
|Details | Review|
When testing bi-directional bookmark syncing, it sometimes appeared to not work but the iOS device had just not synced yet. It required opening Settings to sync. Recommendation: - Allow to pull down on bookmarks to refresh and do a bookmark sync There is a similar behavior already implemented for Synced Tabs view. You can pull down to get the latest device list with the latest open tabs. We should have a similar behavior.
Comment on attachment 8905273 [details] [review] Pull request Great stuff! Once you're ready to land, please needinfo me.
Attachment #8905273 - Flags: review?(jhugman) → review+
Assignee: nobody → joe.gasiorek
Status: NEW → ASSIGNED
Iteration: --- → 1.30
Whiteboard: [sync] → [sync][MobileCore]
I left a question on the diff: this needs to be tested with remotely deleted subfolders.
Updated the PR to address @jhugman's comments. I also left a screen cast of the functionality that @rnewman mentioned - let me know if that should be updated.
@jhugman: Let me know if this needs any additional changes
This PR is a clone of the previous one, to overcome the restriction that the CI server has on it not to build 3rd party PRs.
Merged in to master. Uplifted to 10.x f68ff8463. Well done :joeyg!
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Thanks for all your help :jhugman!
You need to log in before you can comment on or make changes to this bug.