1392761 - Pull Down in Bookmarks to Trigger a Bookmark Sync Refresh

Status: RESOLVED FIXED

(Firefox for iOS :: Sync, enhancement, P1)

Description

[Alex Davis [:adavis]]

When testing bi-directional bookmark syncing, it sometimes appeared to not work but the iOS device had just not synced yet. It required opening Settings to sync.

Recommendation:
- Allow to pull down on bookmarks to refresh and do a bookmark sync

There is a similar behavior already implemented for Synced Tabs view. You can pull down to get the latest device list with the latest open tabs. We should have a similar behavior.

Comment 1

[Joe G]

Attachment: Pull request

Comment 2

[James Hugman [:jhugman] [@jhugman]]

Comment on attachment 8905273 [details] [review]
Pull request

Great stuff!

Once you're ready to land, please needinfo me.

Comment 3

[Richard Newman [:rnewman]]

I left a question on the diff: this needs to be tested with remotely deleted subfolders.

Comment 4

[Joe G]

Updated the PR to address @jhugman's comments. I also left a screen cast of the functionality that @rnewman mentioned - let me know if that should be updated.

Comment 5

[Joe G]

@jhugman: Let me know if this needs any additional changes

Comment 6

[James Hugman [:jhugman] [@jhugman]]

Attachment: Link to Github pull-request: https://github.com/mozilla-mobile/firefox-ios/pull/3240

This PR is a clone of the previous one, to overcome the restriction that the CI server has on it not to build 3rd party PRs.

Comment 7

[James Hugman [:jhugman] [@jhugman]]

Merged in to master. 
Uplifted to 10.x f68ff8463.

Well done :joeyg!

Comment 8

[Joe G]

Thanks for all your help :jhugman!