Closed Bug 1392761 Opened 3 years ago Closed 2 years ago

Pull Down in Bookmarks to Trigger a Bookmark Sync Refresh

Categories

(Firefox for iOS :: Sync, enhancement, P1)

Other
iOS
enhancement

Tracking

()

RESOLVED FIXED
Iteration:
1.30
Tracking Status
fxios 9.2 ---

People

(Reporter: adavis, Assigned: joe.gasiorek, Mentored)

Details

(Whiteboard: [sync][MobileCore])

Attachments

(1 file, 1 obsolete file)

When testing bi-directional bookmark syncing, it sometimes appeared to not work but the iOS device had just not synced yet. It required opening Settings to sync.

Recommendation:
- Allow to pull down on bookmarks to refresh and do a bookmark sync

There is a similar behavior already implemented for Synced Tabs view. You can pull down to get the latest device list with the latest open tabs. We should have a similar behavior.
Priority: -- → P2
Attached file Pull request (obsolete) —
Attachment #8905273 - Flags: review?(jhugman)
Comment on attachment 8905273 [details] [review]
Pull request

Great stuff!

Once you're ready to land, please needinfo me.
Attachment #8905273 - Flags: review?(jhugman) → review+
Assignee: nobody → joe.gasiorek
Mentor: jhugman
Status: NEW → ASSIGNED
Iteration: --- → 1.30
Whiteboard: [sync] → [sync][MobileCore]
I left a question on the diff: this needs to be tested with remotely deleted subfolders.
Updated the PR to address @jhugman's comments. I also left a screen cast of the functionality that @rnewman mentioned - let me know if that should be updated.
Flags: needinfo?(jhugman)
@jhugman: Let me know if this needs any additional changes
Priority: P2 → P1
This PR is a clone of the previous one, to overcome the restriction that the CI server has on it not to build 3rd party PRs.
Attachment #8905273 - Attachment is obsolete: true
Flags: needinfo?(jhugman)
Attachment #8914324 - Flags: review+
Merged in to master. 
Uplifted to 10.x f68ff8463.

Well done :joeyg!
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Thanks for all your help :jhugman!
You need to log in before you can comment on or make changes to this bug.