Closed Bug 1392802 Opened 5 years ago Closed 5 years ago

Local version not incremented after reconciliation of records unchanged locally since last sync

Categories

(Firefox for Android Graveyard :: Android Sync, enhancement, P1)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: Grisha, Assigned: Grisha)

References

Details

Attachments

(1 file)

When bookmark records are merged during sync, local version is only bumped if a record was also modified locally since previous sync. See https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/sync/repositories/android/BookmarksSessionHelper.java?q=path%3ABookmarksSessionHelper.java&redirect_type=single#440

Local version should be bumped if we made _any_ modifications to the record while merging. Otherwise we're going to not upload those changes.
Priority: -- → P1
Assignee: nobody → gkruglov
Status: NEW → ASSIGNED
Comment on attachment 8902490 [details]
Bug 1392802 - Increment localVersion while reconciling a bookmark if we modified its dateAdded t.s.

https://reviewboard.mozilla.org/r/174076/#review179692
Attachment #8902490 - Flags: review?(rnewman) → review+
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a33490d5a193
Increment localVersion while reconciling a bookmark if we modified its dateAdded t.s. r=rnewman
https://hg.mozilla.org/mozilla-central/rev/a33490d5a193
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Depends on: 1395703
Product: Android Background Services → Firefox for Android
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.