Local version not incremented after reconciliation of records unchanged locally since last sync

RESOLVED FIXED in Firefox 57

Status

()

Firefox for Android
Android Sync
P1
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: Grisha, Assigned: Grisha)

Tracking

unspecified
Firefox 57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
When bookmark records are merged during sync, local version is only bumped if a record was also modified locally since previous sync. See https://dxr.mozilla.org/mozilla-central/source/mobile/android/services/src/main/java/org/mozilla/gecko/sync/repositories/android/BookmarksSessionHelper.java?q=path%3ABookmarksSessionHelper.java&redirect_type=single#440

Local version should be bumped if we made _any_ modifications to the record while merging. Otherwise we're going to not upload those changes.
(Assignee)

Updated

5 months ago
Priority: -- → P1
(Assignee)

Updated

5 months ago
Assignee: nobody → gkruglov
(Assignee)

Updated

5 months ago
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 2

5 months ago
mozreview-review
Comment on attachment 8902490 [details]
Bug 1392802 - Increment localVersion while reconciling a bookmark if we modified its dateAdded t.s.

https://reviewboard.mozilla.org/r/174076/#review179692
Attachment #8902490 - Flags: review?(rnewman) → review+

Comment 3

5 months ago
Pushed by gkruglov@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a33490d5a193
Increment localVersion while reconciling a bookmark if we modified its dateAdded t.s. r=rnewman
https://hg.mozilla.org/mozilla-central/rev/a33490d5a193
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
(Assignee)

Updated

5 months ago
Depends on: 1395703

Updated

3 months ago
Product: Android Background Services → Firefox for Android
You need to log in before you can comment on or make changes to this bug.