If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Compilation error in BaseHistoricalBrowserSchema.update

RESOLVED FIXED

Status

()

Firefox for iOS
Build & Test
RESOLVED FIXED
28 days ago
7 days ago

People

(Reporter: st3fan, Unassigned)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios9.0)

Details

(Whiteboard: [MobileCore])

(Reporter)

Description

28 days ago
BaseHistoricalBrowserSchema.update() is missing a return statement. It does have an assert that always fails though. This was probably valid on Swift 3.1. Looks like 3.2 is a bit more strict.
(Reporter)

Updated

28 days ago
Summary: Compilation error in BaseHistoricalBrowserSchema → Compilation error in BaseHistoricalBrowserSchema.update
(Reporter)

Comment 1

28 days ago
https://github.com/mozilla-mobile/firefox-ios/commit/e5dd3fe30a8ba2012f92c7a4bdfe4fec165c2c4e

Landed on master
(Reporter)

Updated

28 days ago
Status: NEW → RESOLVED
Last Resolved: 28 days ago
Resolution: --- → FIXED
(Reporter)

Comment 2

26 days ago
Uplifted to v9.x
Whiteboard: [needsuplift]
Whiteboard: [MobileCore]
You need to log in before you can comment on or make changes to this bug.