1392863 - stylo: followup fixes for restyle roots

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Bobby Holley (:bholley)]

Followups from bug 1383332.

Comment 1

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5be901a542df7c109c6b1c12b38a5ef7d489a377

Comment 2

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ea96b06dc60ba7e6a86ef609536d6ed1d88df547

Comment 3

[Bobby Holley (:bholley)]

Attachment: Part 1 - Clean up DoProcessPendingRestyles. v1

MozReview-Commit-ID: 4JhWFNPVvGn

Comment 4

[Bobby Holley (:bholley)]

Attachment: Part 2 - Eliminate PropagateBitsFromParent. v1

MozReview-Commit-ID: 8rs1mNHMJua

Comment 5

[Bobby Holley (:bholley)]

Attachment: Part 3 - Clean up bit clearing. v1

MozReview-Commit-ID: HQm3wtBtWqT

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8901028 [details] [diff] [review]
Part 3 - Clean up bit clearing. v1

Review of attachment 8901028 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/Element.cpp
@@ +4155,5 @@
>    // places where an element's flattened tree parent changes, and such a change
>    // may also make an element invalid to be used as a restyle root.
> +  //
> +  // Note that we need to null-check aDoc, which may be null in some situations
> +  // when invoked from UnbindFromTree.

Can we assert that we have no data in that case?

Comment 7

[Bobby Holley (:bholley)]

Attachment: Part 4 - Avoid calling ClearServoData with a null document. r=emilio

I'd been trying different configurations on improving this but kept hitting
tricky crashtests. I _think_ this one should finally work.

MozReview-Commit-ID: GyU2gzp0CaA

Comment 8

[Bobby Holley (:bholley)]

https://github.com/servo/servo/pull/18246

Comment 9

[Bobby Holley (:bholley)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b1a64a7e6c8fd29e28fa5cfe0f952bac92600905

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3386f7cad63b
Clean up DoProcessPendingRestyles. r=emilio
https://hg.mozilla.org/integration/autoland/rev/0f8488704d7e
Eliminate PropagateBitsFromParent. r=emilio
https://hg.mozilla.org/integration/autoland/rev/73455899709b
Clean up bit clearing. r=emilio
https://hg.mozilla.org/integration/autoland/rev/71e41a3207c8
Avoid calling ClearServoData with a null document. r=emilio

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/3386f7cad63b
https://hg.mozilla.org/mozilla-central/rev/0f8488704d7e
https://hg.mozilla.org/mozilla-central/rev/73455899709b
https://hg.mozilla.org/mozilla-central/rev/71e41a3207c8