stylo: followup fixes for restyle roots

RESOLVED FIXED in Firefox 57

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bholley, Assigned: bholley)

Tracking

unspecified
mozilla57
Points:
---

Firefox Tracking Flags

(firefox57 fixed)

Details

Attachments

(4 attachments)

(Assignee)

Description

a year ago
Followups from bug 1383332.
(Assignee)

Comment 3

a year ago
Created attachment 8901026 [details] [diff] [review]
Part 1 - Clean up DoProcessPendingRestyles. v1

MozReview-Commit-ID: 4JhWFNPVvGn
Attachment #8901026 - Flags: review?(emilio+bugs)
(Assignee)

Comment 4

a year ago
Created attachment 8901027 [details] [diff] [review]
Part 2 - Eliminate PropagateBitsFromParent. v1

MozReview-Commit-ID: 8rs1mNHMJua
Attachment #8901027 - Flags: review?(emilio+bugs)
(Assignee)

Comment 5

a year ago
Created attachment 8901028 [details] [diff] [review]
Part 3 - Clean up bit clearing. v1

MozReview-Commit-ID: HQm3wtBtWqT
Attachment #8901028 - Flags: review?(emilio+bugs)
Attachment #8901026 - Flags: review?(emilio+bugs) → review+
Attachment #8901027 - Flags: review?(emilio+bugs) → review+
Comment on attachment 8901028 [details] [diff] [review]
Part 3 - Clean up bit clearing. v1

Review of attachment 8901028 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/Element.cpp
@@ +4155,5 @@
>    // places where an element's flattened tree parent changes, and such a change
>    // may also make an element invalid to be used as a restyle root.
> +  //
> +  // Note that we need to null-check aDoc, which may be null in some situations
> +  // when invoked from UnbindFromTree.

Can we assert that we have no data in that case?
Attachment #8901028 - Flags: review?(emilio+bugs) → review+
(Assignee)

Comment 7

a year ago
Created attachment 8901381 [details] [diff] [review]
Part 4 - Avoid calling ClearServoData with a null document. r=emilio

I'd been trying different configurations on improving this but kept hitting
tricky crashtests. I _think_ this one should finally work.

MozReview-Commit-ID: GyU2gzp0CaA
Attachment #8901381 - Flags: review+

Comment 10

a year ago
Pushed by bholley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3386f7cad63b
Clean up DoProcessPendingRestyles. r=emilio
https://hg.mozilla.org/integration/autoland/rev/0f8488704d7e
Eliminate PropagateBitsFromParent. r=emilio
https://hg.mozilla.org/integration/autoland/rev/73455899709b
Clean up bit clearing. r=emilio
https://hg.mozilla.org/integration/autoland/rev/71e41a3207c8
Avoid calling ClearServoData with a null document. r=emilio

Comment 11

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/3386f7cad63b
https://hg.mozilla.org/mozilla-central/rev/0f8488704d7e
https://hg.mozilla.org/mozilla-central/rev/73455899709b
https://hg.mozilla.org/mozilla-central/rev/71e41a3207c8
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.