1392871 - Revisit the balrog multiple-signoff mechanism to see who from QE/relman/releng needs to be available during the release process

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Comment 1

[Kim Moir [:kmoir] ET]

Currently, for betas, when the balrog signoff looks like

1) Desktop 
QE, Relman, releng
2) Devedition
releng, Relman

for Desktop releases the signoff is
1) QE, Relman, releng

If we need to make a change after a release, i.e. add a rule to disable updates 24 hrs after a release, qe, relman and releng also need to sign off.  Same for disabling all updates. (In an emergency, there is a way to circumvent these rules, see https://github.com/mozilla/releasewarrior/blob/master/how-tos/relpro.md#working-around-signoffs-in-balrog)

However, we should revisit if all these signoffs are required and indeed useful

My initial proposal is to
1) remove QE from signoffs from beta as they have already signed off on tests on the appropriate cdntest channel as part of their testing
2) Remove QE from signoffs to disable updates/change update rates after a release because this kind of request often happens after hours is usually a request from relman for releng.  If we do continue to have all three groups to sign off, is there an escalation process to reach everyone out of regular business hours other than looking up people's phone numbers in phonebook? 

Thoughts?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Both of those proposals sound reasonable to me.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Yes, I agree with you on all these points. Thanks Kim.

Comment 4

[Kim Moir [:kmoir] ET]

So I just checked the permissions. To be honest I didn't know I could change this myself, and I should have looked at how it was structured before my earlier comments.
 
https://aus4-admin.mozilla.org/required_signoffs

The way the rules are implemented it's on a per channel basis. So if this was implemented, I would also be removing qe from signing off on the release channel, not just removing them signing off on updating rates/turning off updates after a release.  I assume that's okay, let me know if there are any objections.

Comment 5

[Kim Moir [:kmoir] ET]

This pending change needs to be signed off by qe and relman in balrog

Go to 
https://aus4-admin.mozilla.org/required_signoffs
select Firefox as the product in the upper right hand corner

and sign off on the change for beta and release

Comment 6

[Kim Moir [:kmoir] ET]

RyanVM, qe is not signed off on the Firefox product

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Sorry, I missed that part.

Comment 8

[Kim Moir [:kmoir] ET]

Thanks, this is done now!