1392927 - [Form Autofill] The update door hanger does not pop-up when fields are filled by website and modified later

Status: NEW

(Toolkit :: Form Autofill, defect, P3)

Description

[Gabi Cheta [:Gabi] Desktop QA]

[Environment:]
Ubuntu 16.04 64bit, Mac Osx 10.12.6

56.0b4 20170822073240

[Steps:]

Preconditions
Go to Preferences/ Privacy and Security / Form Autofill / Enable Profile autofill. (default in Nightly)
Make sure you have at least one saved address.
Amazon valid account


1. Open Firefox
2. Navigate to Amazon.com and login with a valid account
3. From the right corner hover Account &Lists and select account
4. Click On Addresses button
5. Click on Add Address
6. Double click On Full name
7. When address is auto-filled select something to modify e.g Street name
8. Click Add button
9. Click Update Address when auto-fill pop up is displayed
10. Modify the address again and tap Add


[Actual Result:]
Door hanger does not popup the 2nd time the address was modified,
2 Addresses are saved in Preferences/Saved Addresses


[Expected Result:]
Door hanger should appear when the amazon address is modified the 2nd time

[Note:]
Door hanger popup reappears when the page is refreshed

Comment 1

[Gabi Cheta [:Gabi] Desktop QA]

Investigated further and using mozregression I got the following pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=a6a1f5c1d971dbee67ba6eec7ead7902351ddca2&tochange=4f4487cc2d30d988742109868dcf21c4113f12f5
Hope this helps.

Comment 2

[Luke Chang [:lchang] (inactive)]

NI Sean for following up.

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Hi Gabi,

In step 10, do you see any highlight inputs?
> 10. Modify the address again and tap Add

IIUC, the edit form without any highlight is autofilled by Amazon.com rather than Firefox FormAutofill feature.
When "Save Changes" button clicked, Firefox considers the new profile that the browser won't show door-hanger for. 
The doorhanger won't show up for a new address based on the spec [1]:
> Once the doorhanger is dismissed, the address data would be saved and the doorhanger will not be shown again.
> The new addresses will be saved automatically in the future.

If you think I use the same way to reproduce your step, I will let UX designer know the behavior.

Thanks.

[1] https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/185446463

Comment 4

[Gabi Cheta [:Gabi] Desktop QA]

(In reply to Sean Lee [:seanlee][:weilonge] from comment #3)
> Hi Gabi,
> 
> In step 10, do you see any highlight inputs?
> > 10. Modify the address again and tap Add
> 
> IIUC, the edit form without any highlight is autofilled by Amazon.com rather
> than Firefox FormAutofill feature.
> When "Save Changes" button clicked, Firefox considers the new profile that
> the browser won't show door-hanger for. 
> The doorhanger won't show up for a new address based on the spec [1]:
> > Once the doorhanger is dismissed, the address data would be saved and the doorhanger will not be shown again.
> > The new addresses will be saved automatically in the future.
> 
> If you think I use the same way to reproduce your step, I will let UX
> designer know the behavior.
> 
> Thanks.
> 
> [1] https://mozilla.invisionapp.com/share/AP8TFZ22G#/screens/185446463

@Sean Lee, there's no highlight input after editing and saving the address again.

Comment 5

[Luke Chang [:lchang] (inactive)]

Hi Gabi,

According to comment 4, the address profile you saw in "Edit your address" page in step 10 was actually filled by Amazon instead of our Form Autofill feature. It should be treated as a profile that is manually filled by a user. In this case, it's by design that the update doorhanger won't be invoked because no saved profile has been involved and we don't know which profile should be updated.

I admit this behavior might confuse users. We'll consult UX to see if we can deal with it properly. However, it'll be a new feature rather than a regression and is out of scope in MVP. In the meantime, I think it's not a blocker of beta 56.


(In reply to Gabi Cheta from comment #0)
> [Note:]
> Door hanger popup reappears when the page is refreshed

In addition, Sean and I can't reproduce this. Would you mind recording your steps? Thanks.

Comment 6

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: autofill.gif

Comment 7

[Gabi Cheta [:Gabi] Desktop QA]

(In reply to Gabi Cheta from comment #6)
> Created attachment 8903042 [details]
> autofill.gif

(In reply to Luke Chang [:lchang] from comment #5)
> Hi Gabi,
> 
> According to comment 4, the address profile you saw in "Edit your address"
> page in step 10 was actually filled by Amazon instead of our Form Autofill
> feature. It should be treated as a profile that is manually filled by a
> user. In this case, it's by design that the update doorhanger won't be
> invoked because no saved profile has been involved and we don't know which
> profile should be updated.
> 
> I admit this behavior might confuse users. We'll consult UX to see if we can
> deal with it properly. However, it'll be a new feature rather than a
> regression and is out of scope in MVP. In the meantime, I think it's not a
> blocker of beta 56.
> 
> 
> (In reply to Gabi Cheta from comment #0)
> > [Note:]
> > Door hanger popup reappears when the page is refreshed
> 
> In addition, Sean and I can't reproduce this. Would you mind recording your
> steps? Thanks.

Hi, added the recorded steps requested.

Comment 8

[Luke Chang [:lchang] (inactive)]

I see. In your steps you clicked "Add Address" three times. What happened in each time are:

1. You autofilled a profile and didn't change any field. No doorhanger is necessary.

2. The page wasn't refreshed and fields remained highlighted so it's treated as autofilled, too. Then you changed one field. The update doorhanger showed as expected.

3. The page was then refreshed and the data in fields were filled by website instead so no field was highlighted. When you changed one field again and submitted it, it was treated as a new profile user typed manually like I mentioned in comment 5. Therefore, profile was saved as a new one without doorhanger invoked.

Things happened here are as expected but may be confusing. NI Juwei to see if we can make it better in the next version.

Comment 9

[Juwei Huang[:juwei]]

It's indeed a tricky use case. However, in any of the cases, the addresses would be saved to Firefox anyway and users don't have to re-type their address again. So I think it won't harm overall experience.

Comment 10

[Gabi Cheta [:Gabi] Desktop QA]

(In reply to Luke Chang [:lchang] from comment #8)
> I see. In your steps you clicked "Add Address" three times. What happened in
> each time are:
> 
> 1. You autofilled a profile and didn't change any field. No doorhanger is
> necessary.
> 
> 2. The page wasn't refreshed and fields remained highlighted so it's treated
> as autofilled, too. Then you changed one field. The update doorhanger showed
> as expected.
> 
> 3. The page was then refreshed and the data in fields were filled by website
> instead so no field was highlighted. When you changed one field again and
> submitted it, it was treated as a new profile user typed manually like I
> mentioned in comment 5. Therefore, profile was saved as a new one without
> doorhanger invoked.
> 
> Things happened here are as expected but may be confusing. NI Juwei to see
> if we can make it better in the next version.

Hi Luke, the gif I attached is maybe a little confusing because at step 1. I did not click "Add Address" button(Sorry).

Once the amazon from is autofilled from the Saved Addresses, I modified a field and clicked on "Add Address" button, the doorhanger appeared as expected and clicked on Update Address option.

Next, I modified another field and clicked the Add Address button for which the door-hanger did appeared and the address was saved as a new one under "Saved Addresses". My concern here is that if an already saved address is modified multiple times on amazon.com we'll end up with a lot of different version of the same address profiles saved in Preferences.

Comment 11

[Luke Chang [:lchang] (inactive)]

(In reply to Gabi Cheta from comment #10)
> My concern here is that if an already saved address is modified multiple times on amazon.com we'll end up with a lot of different version of the same address profiles saved in Preferences.

Yes, it's expected. We don't know any context about websites you're browsing so we're not able to know you are submitting a new form or just modifying the one saved in website -- even though it was created based on the autofill's result previously.

Though there won't be a lot of "the same address profiles" because mergeable profiles will be merged. For example, you save A at first and then change it to B. B will be saved as a new profile. If you change it back to A afterward, there won't be another A saved because we detect that it's identical to the existing one. We do intend to save as many profiles as we can if you intentionally submit a lot of different profiles in order not to miss any data.