Add support for AudioSampleEntry with a version 2 (QT Extension)

RESOLVED FIXED in Firefox 58

Status

()

enhancement
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jya, Assigned: ayang)

Tracking

Trunk
mozilla58
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox58 fixed)

Details

Attachments

(2 attachments)

Reporter

Description

2 years ago
FFmpeg can create AudioSampleEntry (in a stsd box) that have a version of value 2.

They store:
        avio_wb16(pb, 3);
        avio_wb16(pb, 16);
        avio_wb16(pb, 0xfffe);
        avio_wb16(pb, 0);
        avio_wb32(pb, 0x00010000);
        avio_wb32(pb, 72);
        avio_wb64(pb, av_double2int(track->par->sample_rate));
        avio_wb32(pb, track->par->channels);
        avio_wb32(pb, 0x7F000000);
        avio_wb32(pb, av_get_bits_per_sample(track->par->codec_id));
        avio_wb32(pb, mov_get_lpcm_flags(track->par->codec_id));
        avio_wb32(pb, track->sample_size);
        avio_wb32(pb, get_samples_per_packet(track));
https://dxr.mozilla.org/mozilla-central/rev/1867d7931c0a70ab90edf4aa84876525773a7139/media/libstagefright/frameworks/av/media/libstagefright/MPEG4Extractor.cpp#1251

Such box are QT v2 extension where support was added in stagefright in bug 1130450. But this hasn't been implemented in the rust mp4parse.

In such structure, the sampling rate is stored in a double (64 bits).
Mass change P1->P2 to align with new Mozilla triage process
Priority: P1 → P2
Assignee

Updated

2 years ago
Assignee: nobody → ayang
Assignee

Comment 2

2 years ago
Posted video gizmo-short.mov
Created with ffmpeg.

ffmpeg -i ./gizmo-short.mp4 -acodec pcm_s16le -ar 96000 -vcodec copy -f mov gizmo-short.mov
Comment hidden (mozreview-request)

Comment 5

2 years ago
mozreview-review
Comment on attachment 8926181 [details]
Bug 1393045 - support QT AudioSampleEntry v2.

https://reviewboard.mozilla.org/r/197432/#review202634
Attachment #8926181 - Flags: review?(kinetik) → review+

Comment 6

2 years ago
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/78f97c364749
support QT AudioSampleEntry v2. r=kinetik

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/78f97c364749
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Assignee

Updated

2 years ago
See Also: → 1415807
You need to log in before you can comment on or make changes to this bug.