1393049 - Download button not visible by default on latest 20170823100553 nightly

Status: RESOLVED DUPLICATE of bug 1393213

(Firefox :: Downloads Panel, defect)

Description

[Clément Lefèvre]

In latest nightly, the arrow to manage downloads isn't here anymore.

After investigating it looks like it appears if user is doing a download but stays hidden otherwise.
The arrow isn't in the customize menu, and if it's here because user started a download, it's greyed out and can't be moved.

Considering the horizontal menu at the top of the window is by default not visible on two out of the three main platforms (Linux and Windows), it makes it impossible to easily access to the download window for most of the users if they do not start a download.

The fact the button can appear or disappear if user restart the browser  is a think a not so bad idea, but can be confusing for many users, same goes for the fact it's impossible to move that button (to what is it anchored by the way?).

We're two users on IRC who noticed that on #nightly and thought at first there was a bug and the button was totally missing.

One good option can be to have a download section in the library button/menu. I thought it used to be there but was wrong. It could be, in my humble opinion, a viable option.

Comment 1

[WaltS48 [:walts48]]

I can confirm on the Linux Nightly BuildID: 20170823100553.

Checking my Windows Nightly, but it only just updated to BuildID: 20170822171841, which does have the Download button visible on the toolbar.

Comment 2

[:Paolo Amadini]

(In reply to Clément Lefèvre from comment #0)
> One good option can be to have a download section in the library
> button/menu. I thought it used to be there but was wrong. It could be, in my
> humble opinion, a viable option.

Yes, this is bug 1354532 which will hopefully land in Nightly very soon.

Comment 3

[Clément Lefèvre]

Yes, didn't specified, but it was reproduced on Linux for the abovementioned cases.
Can't check Windows or OS X right now.

Comment 4

[Clément Lefèvre]

(In reply to :Paolo Amadini from comment #2)
> (In reply to Clément Lefèvre from comment #0)
> > One good option can be to have a download section in the library
> > button/menu. I thought it used to be there but was wrong. It could be, in my
> > humble opinion, a viable option.
> 
> Yes, this is bug 1354532 which will hopefully land in Nightly very soon.

Should the bug still be closed as a dupe?
I think there are two more concerns here:
- A button appearing and disappearing.
- The fact this button can't be moved, isn't visible in customize if there were no downloads in the current session and it is if there were downloads.

Comment 5

[:Paolo Amadini]

(In reply to Clément Lefèvre from comment #4)
> I think there are two more concerns here:
> - A button appearing and disappearing.

This is part of the new Photon design and was implemented in bug 1371765. As you noted, bug 1354532 will provide an alternate access point for past downloads and for the Library window.

> - The fact this button can't be moved, isn't visible in customize if there
> were no downloads in the current session and it is if there were downloads.

I missed this, the button should probably be hidden when we enter Customize mode. Gijs?

Comment 6

[:Gijs (he/him)]

(In reply to :Paolo Amadini from comment #5)
> (In reply to Clément Lefèvre from comment #4)
> > I think there are two more concerns here:
> > - A button appearing and disappearing.
> 
> This is part of the new Photon design and was implemented in bug 1371765. As
> you noted, bug 1354532 will provide an alternate access point for past
> downloads and for the Library window.
> 
> > - The fact this button can't be moved, isn't visible in customize if there
> > were no downloads in the current session and it is if there were downloads.
> 
> I missed this, the button should probably be hidden when we enter Customize
> mode. Gijs?

TBH, not sure I would agree with this. Seems fine to let the user move it within the toolbar once visible, once bug 1387313 lands.

In any case, we can look into this when Bryan replies / decides about the apposite bug - bug 1393080. Not much point doing it before then.

Comment 8

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Let's mark this as duplicate of bug #1393213, as this change is being re-evaluated and this bug was first about it, looking on OP post and old not changed summary.