Closed Bug 1393072 Opened 4 years ago Closed 4 years ago

(photon) Small tablets: in private mode, the bookmark & share icons are not visible

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

57 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox57 verified)

VERIFIED FIXED
Firefox 57
Tracking Status
firefox57 --- verified

People

(Reporter: oana.horvath, Assigned: jwu)

References

Details

(Whiteboard: [FNC][SPT57.3][MVP])

Attachments

(3 files)

Device:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Huawei MediaPad M2 (Android 5.1.1)
*Not an issue on larger tablets as: HTC Nexus 9 (Android 7.1.1)

Build: Nightly 57.0a1 (2017-08-23);

Steps to reproduce:
1. Open a private tab and tap the custom menu. 
2. Check the bookmark and the share icons in an inactive state. 
3. Open a page in the private tab. Check the icons again as available.

Expected result:
Icons should be visible.

Actual result:
See screenshots. On smaller tablets, as the ones mentioned here, the bookmark icon is displayed on the custom menu overlay. Not in the toolbar, as on larger screens. 

Notes: Probably the custom menu would be good to have a darker theme in private mode too, so this would solve this issue and also would fit in the whole private mode theme.
Attached image PM - icons -on page.png
Whiteboard: [FNC][SPT57.3][BL]
Whiteboard: [FNC][SPT57.3][BL] → [FNC][SPT57.3][MVP]
Assignee: nobody → topwu.tw
Comment on attachment 8904394 [details]
Bug 1393072 - Only tint light color for menu icons in private mode in large tablet.

https://reviewboard.mozilla.org/r/176196/#review181164
Attachment #8904394 - Flags: review?(cnevinchen) → review+
Pushed by topwu.tw@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/00f4b42eb881
Only tint light color for menu icons in private mode in large tablet. r=nechen
https://hg.mozilla.org/mozilla-central/rev/00f4b42eb881
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Verified as fixed on Nightly 57 (2017-09-18).
Devices:
Asus ZenPad 8.0 Z380KL (Android 6.0.1)
Huawei MediaPad M2 (Android 5.1.1)
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.