1393129 - When opening "Bookmark all tabs" dialog, the folder field flickers - shows one value and then changes

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[nivtwig]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0
Build ID: 20170822171841

Steps to reproduce:

Open many tabs, or restore a session with many tabs (so most of them are not loaded), right click over one of the tabs, and choose "Bookmark all tabs..."


Actual results:

Look carefully at the opening of the "Bookmark all tabs" dialog. 
With 77 tabs, there is a "blinking" of the Folder field contents : it changes from "Bookmarks Toolbar" and yellow icon at the left, to "Bookmarks menu" with a gray icon to the left.

With 880 tabs, this happens more slowly and takes 1-2 seconds. When the 2 input fields are shown and the "Add bookmarks" button changes from disabled to enabled after data gathering is probably finished, you see initially the folder field contents set to "Bookmarks toolbar" with a yellow icon at the beginning, and after 1-2 seconds, it changes to "Bookmarks Menu" with a gray icon. 



Expected results:

The field should be shown immediately with its final content without blinking/changing

I think it is a regression caused by the fix for bug 1385733, since I think I haven't noticed this before, but I am not sure.

Comment 1

[Marco Bonardo [:mak]]

Remove feature blocking, this is not critical.