139313 - fatal warning in buglist.cgi

Status: RESOLVED FIXED

(Bugzilla :: Query/Bug List, defect)

Description

[Cédric Caron]

On my test system the folowing code in buglist.cgi when i select the "my bugs" 
query

if (trim($::FORM{'votes'}) && !grep($_ eq 'votes', @displaycolumns)) {
    push(@displaycolumns, 'votes');
}

generate a warning

[Tue Apr 23 00:30:47 2002] C:\Projects\bugzilla\Current\buglist.cgi: Use of 
uninitialized value in substitution (s///) at globals.pl line 1587.
Use of uninitialized value in substitution (s///) at globals.pl line 1588 (#1)
[Tue Apr 23 00:30:47 2002] C:\Projects\bugzilla\Current\buglist.cgi: Use of 
uninitialized value in substitution (s///) at globals.pl line 1588.
Content-Disposition: inline; filename=bugs-2002-04-23.html

Unfortunatly this warning corupt the HTML generated and the page is not 
displayed corectly

Comment 1

[Dave Miller [:justdave]]

what's the version number (from 'cvs status globals.pl') on your globals.pl
file?  There doesn't look like there's anything remotely resembling a possible
concatenation ocurring at those line numbers on the tip, so I'm trying to hunt
down what line it's on...   on the other hand, maybe you have something hacked
in globals.pl to make it work on Windows. :-)   Can you figure out which lines
those are and post some context?

In any case, uninitialized value shouldn't be fatal...

Comment 2

[Dave Miller [:justdave]]

doh, you had context, I'm blind.  Let me look again.

Comment 3

[Dave Miller [:justdave]]

ok, but I can't find the code you list anywhere in globals.pl.  Is this fixed
already on the tip?

Comment 4

[Cédric Caron]

the code I listed is in line 1230 of buglist.cgi and call the function trim in 
global.cgi line 1526

Comment 5

[Cédric Caron]

Attachment: my patch

This patch is working for me but I am not a perl expert......

Comment 6

[Dave Miller [:justdave]]

Looks pretty trivial to me...  but before I stamp an r= on it I'm curious why
this isn't defined to begin with....

Comment 7

[Bradley Baetz (:bbaetz)]

if you don't have voting enabled, maybe? The template doesn't imply that you can
skip it though.

Manually editing bug query lines, bookmarks, or the my bugs link would show
this, I suppose.

Is this really fatal? Should just adding a check for votes being defined, first,
be better, or would that just cause the wame warning later?

Comment 8

[Cédric Caron]

I reseted the mybugstemplate param, activated the votes and voted for 1 bug but 
I still have the problem

buglist.cgi already contain others lines like the one I added (line 94, 132)

I just added one...

Comment 9

[Bradley Baetz (:bbaetz)]

Comment on attachment 82061 [details] [diff] [review]
my patch

ok, wfm. r=bbaetz x2

Comment 10

[Bradley Baetz (:bbaetz)]

-> patch author....

Comment 11

[Bradley Baetz (:bbaetz)]

and checked in