Closed Bug 1393158 Opened 7 years ago Closed 7 years ago

Download toolbar button should always be visible (breaks the assumption in browser_indicatorDrop.js)

Categories

(Firefox :: Toolbars and Customization, enhancement)

Product:
Firefox
Component:
Toolbars and Customization
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1393103

People

(Reporter: arai, Unassigned)

Details

the change in bug 1371765 almost regressed the following test's assumption: https://dxr.mozilla.org/mozilla-central/source/browser/components/downloads/test/browser/browser_indicatorDrop.js the test works because of the test framework's restriction, that is, it's not using pure drag-and-drop event, but using pseudo one that can be dispatched to hidden element, but the testcase assumes the button is visible. (should I add a code that checks visibility there?) the download button is there also for accepting drag-and-drop (see also bug 1393103), in addition to indicating the download progress and providing dropdown menu. so, to follow the summary of the bug 1371765 - "Only show the downloads button when necessary", it should always be shown.
See Also: → 1393160
There's no point having a separate bug open for this.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
See Also: 1393103 →
See Also: 1393160 →
You need to log in before you can comment on or make changes to this bug.