1393220 - UITour: The first highlight is positioned far too left

Status: RESOLVED WORKSFORME

(Firefox :: Tours, defect, P5)

Description

[Stefan [:StefanG_QA]]

Attachment: Highligh is shifted to the left on RTL-ar locale.JPG

+++ This bug was initially created as a clone of Bug #1049130 +++

The first highlight after startup on RTL locale (ar)(e.g. on the menu button or the account Status) is offset to the left from where it should be.

STR: 
1. Launch Nightly 57
2. Wait for Onboarding tour to be shown
3. Open a new tab
4. Click on Performance notification
5. Close the notification window
6. Open a new tab 
7. Click on Private Browsing notification 
8. Press the blue button "Show Private Browsing in Menu"
9. Observe the highlight position
 
Note: if the issue is not shown repeat steps 6 to 8 

AR: The highlight is shifted to the left
ER: The highlight should be placed to the correct position

Check the attached screenshot showing the issue.

The issue is not reproducible on LTR builds on any platform.

Comment 1

[Evan Tseng [:evanxd]]

Attachment: rtl-onboarding.png

Hi Stefan,

I could not reproduce this with the current (Mon Aug 28 17:38:53 2017 -0700) mozilla-central build. Maybe this issue already fixed by another commit?

And I switch to the RTL mode with setting the `intl.uidirection` pref as `1` in about:config page.

Could you try it again?

Thank you.

Comment 2

[Stefan [:StefanG_QA]]

Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0 (20170829100404)

Hi Evan,

I'm still able to reproduce the issue on Ubuntu 17.04 x64 using latest Nightly build and the below steps. 

STR: 
1. Launch Nightly 57
2. browser.onboarding.notification.mute-duration-on-first-session-ms = 30
3. Open a new tab
4. Click on Performance notification
5. In the UI tour click on the Private Browser
6. Press the blue button "Show Private Browsing in Menu"
7. Observe the highlight position

Note: if the issue is not reveal repeat steps 3 to 6
 
AR: The highlight is shifted to the left
ER: The highlight should be placed to the correct position

I can not reproduce the issue using en-US build with `intl.uidirection` pref set `1`.

Comment 3

[Evan Tseng [:evanxd]]

Attachment: Cannot reproduce this issue

Comment 4

[Evan Tseng [:evanxd]]

Hi Stefan,

I downloaded today's Firefox Nightly and tried the STR for 10 times in the attachment 8902581 [details] video, but I still could not reproduce this issue on my ubuntu 16.04 x64 machine.

Could you check the video to see if I misunderstood something of STR?

Thank you.

Comment 5

[Stefan [:StefanG_QA]]

I've used the same steps as you to reveal the issue. Please check the video I've made showing the issue. 

https://St3fQA.tinytake.com/sf/MTkyMTEzOF82MTE4NjAx

I noticed that the hamburger menu is shifted to the right when opened from the UI Tour. The menu is shown starting from the bottom right corner of the button. 

This does not happened if I click the hamburger menu, then the menu is shown correctly.

Comment 6

[[e-mail]]

In video at 0.40s, the MENU is showing correctly at first glance, then the whole menu shifted right a bit.

Does it only happens when maximize the window, or is it also happen with the smaller window?

Comment 7

[Stefan [:StefanG_QA]]

I'm able to reproduce the issue either if I expand the window to the max width or with the window maximized.

In all other scenarios I`m unable to reproduce the issue.

Comment 8

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals

Comment 9

[Rares Doghi, Desktop QA]

This issue no longer exists in our latest Builds as we no longer have those Firefox Tours. Closing for now.