Closed Bug 1393229 Opened 3 years ago Closed 3 years ago

Add macOS tp6 runs for Stylo

Categories

(Testing :: Talos, enhancement, P1)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: jryans, Assigned: jryans)

References

Details

(Whiteboard: [Stylo])

Attachments

(3 files)

In bug 1387265, the Stylo version was skipped because it appeared to fail.  Let's fix that and turn it on.
The core issue appears to be that we need to be sure we use string for env vars on macOS.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=19f34e7d439b4652931cef96d0d79b1ca926c0f0
Comment on attachment 8900472 [details]
Bug 1393229 - Log browser env for Talos runs.

https://reviewboard.mozilla.org/r/171832/#review177118

this is useful!
Attachment #8900472 - Flags: review?(jmaher) → review+
Comment on attachment 8900473 [details]
Bug 1393229 - Stylo env vars must be a string value.

https://reviewboard.mozilla.org/r/171834/#review177120

thanks!
Attachment #8900473 - Flags: review?(jmaher) → review+
Comment on attachment 8900474 [details]
Bug 1393229 - Enable tp6s and tp6st for macOS with Stylo.

https://reviewboard.mozilla.org/r/171836/#review177122

small nit, otherwise, awesome

::: taskcluster/ci/test/tests.yml:1909
(Diff revision 1)
>      treeherder-symbol: tc-Ts(tp6s)
>      virtualization: hardware
>      run-on-projects:
>          by-test-platform:
>              windows.*: ['mozilla-beta', 'mozilla-central', 'mozilla-inbound', 'autoland', 'try']
> -            macosx64-stylo/.*: []
> +            macosx.*: ['mozilla-central', 'try']

I think mozilla-beta as well, that way we don't have to edit this in the future.

::: taskcluster/ci/test/tests.yml:1935
(Diff revision 1)
>      treeherder-symbol: tc-Ts(tp6st)
>      virtualization: hardware
>      run-on-projects:
>          by-test-platform:
>              windows.*: ['mozilla-beta', 'mozilla-central', 'mozilla-inbound', 'autoland', 'try']
> -            macosx64-stylo/.*: []
> +            macosx.*: ['mozilla-central', 'try']

again, mozilla-beta.
Attachment #8900474 - Flags: review?(jmaher) → review+
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/611bd823120e
Log browser env for Talos runs. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/6f4cae1f3fdf
Stylo env vars must be a string value. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/4555ca9b5911
Enable tp6s and tp6st for macOS with Stylo. r=jmaher
You need to log in before you can comment on or make changes to this bug.