1393229 - Add macOS tp6 runs for Stylo

Status: RESOLVED FIXED

(Testing :: Talos, enhancement, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 1387265, the Stylo version was skipped because it appeared to fail.  Let's fix that and turn it on.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

The core issue appears to be that we need to be sure we use string for env vars on macOS.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=19f34e7d439b4652931cef96d0d79b1ca926c0f0

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1393229 - Log browser env for Talos runs.

Output the environment that will be used to launch the browser.  This ensures we
catch any last minute tweaks, like enabling Stylo or other features.

Review commit: https://reviewboard.mozilla.org/r/171832/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171832/

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1393229 - Stylo env vars must be a string value.

On at least macOS, it appears you have to ensure all environment values are
strings only (not integers or other types).

Review commit: https://reviewboard.mozilla.org/r/171834/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171834/

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1393229 - Enable tp6s and tp6st for macOS with Stylo.

Review commit: https://reviewboard.mozilla.org/r/171836/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/171836/

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8900472 [details]
Bug 1393229 - Log browser env for Talos runs.

https://reviewboard.mozilla.org/r/171832/#review177118

this is useful!

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8900473 [details]
Bug 1393229 - Stylo env vars must be a string value.

https://reviewboard.mozilla.org/r/171834/#review177120

thanks!

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8900474 [details]
Bug 1393229 - Enable tp6s and tp6st for macOS with Stylo.

https://reviewboard.mozilla.org/r/171836/#review177122

small nit, otherwise, awesome

::: taskcluster/ci/test/tests.yml:1909
(Diff revision 1)
>      treeherder-symbol: tc-Ts(tp6s)
>      virtualization: hardware
>      run-on-projects:
>          by-test-platform:
>              windows.*: ['mozilla-beta', 'mozilla-central', 'mozilla-inbound', 'autoland', 'try']
> -            macosx64-stylo/.*: []
> +            macosx.*: ['mozilla-central', 'try']

I think mozilla-beta as well, that way we don't have to edit this in the future.

::: taskcluster/ci/test/tests.yml:1935
(Diff revision 1)
>      treeherder-symbol: tc-Ts(tp6st)
>      virtualization: hardware
>      run-on-projects:
>          by-test-platform:
>              windows.*: ['mozilla-beta', 'mozilla-central', 'mozilla-inbound', 'autoland', 'try']
> -            macosx64-stylo/.*: []
> +            macosx.*: ['mozilla-central', 'try']

again, mozilla-beta.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8900474 [details]
Bug 1393229 - Enable tp6s and tp6st for macOS with Stylo.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/171836/diff/1-2/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/611bd823120e
Log browser env for Talos runs. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/6f4cae1f3fdf
Stylo env vars must be a string value. r=jmaher
https://hg.mozilla.org/integration/autoland/rev/4555ca9b5911
Enable tp6s and tp6st for macOS with Stylo. r=jmaher

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/611bd823120e
https://hg.mozilla.org/mozilla-central/rev/6f4cae1f3fdf
https://hg.mozilla.org/mozilla-central/rev/4555ca9b5911