1393289 - Port Bug 831094 "Avoid replacing nodes in Places query results and remove nodeReplaced views notification" to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #831094 +++

basically, it always replaces nodes, when often it could just update them, that means:
let root = PlacesUtils.history.executeQuery(query, options).root; root.containerOpen = true;
let node = root.getChild(0);
// add a visit or change title or whatever...
node != root.getChild(0);

moreover if this is an history query with SORT_BY_NONE sorting, insertions can change sorting order of entries (are likely done in the wrong place).

see https://bugzilla.mozilla.org/show_bug.cgi?id=752217#c12

Both are totally unpredictable for a consumer, even if it always worked like this.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1393289-nodereplaced.patch

[Approval Request Comment]
Regression caused by (bug #): 831094
User impact if declined: Dead code.
Testing completed (on m-c, etc.): c-b
Risk to taking this patch (and alternatives if risky): no longer used code.
String changes made by this patch: none

Comment 2

[Ian Neal]

Comment on attachment 8900517 [details] [diff] [review]
1393289-nodereplaced.patch

You missed one, https://dxr.mozilla.org/comm-central/source/suite/common/places/browserPlacesViews.js#1234

r/a=me with that fixed

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6f0a2d5d6ca6
Port Bug 831094 to SeaMonkey. Remove no longer called nodeReplaced function. r=IanN

Comment 4

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-beta/rev/17d020d0e56884641227b5552ecb7516a3289853