Closed
Bug 1393301
Opened 8 years ago
Closed 7 years ago
Clean up Colors in UIConstants.swift
Categories
(Firefox for iOS :: Browser, enhancement, P3)
Tracking
()
RESOLVED
FIXED
| Tracking | Status | |
|---|---|---|
| fxios | 10.0 | --- |
People
(Reporter: farhan, Unassigned)
Details
(Whiteboard: [Photon])
Attachments
(1 file)
UIConstants contains a lot of different colors. Can we clean it up so changing the colors is a simple process of changing one file.
Maybe make a new Struct called BrowserColors and have the colors in there.
Also move the colors that exist in the theme struct into BrowserColors/UIConstants so they are easier to find.
|
Reporter | |
Updated•8 years ago
|
Whiteboard: [MobileAS][PocketStories] → [Photon]
|
|
Reporter | |
Updated•7 years ago
|
Priority: -- → P2
|
||
Updated•7 years ago
|
Priority: P2 → P3
|
|
Reporter | |
Comment 1•7 years ago
|
||
Attachment #8926990 -
Flags: review?(jdarcangelo)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8926990 [details]
Pull Request
A couple of small nits and questions about confusing comments, but otherwise LGTM!
Attachment #8926990 -
Flags: review?(jdarcangelo) → review+
|
|
Reporter | |
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•