Closed Bug 1393321 Opened 2 years ago Closed 2 years ago

Define MOZ_ANDROID_POCKET from config

Categories

(Firefox for Android :: General, enhancement, P1)

ARM
Android
enhancement

Tracking

()

RESOLVED FIXED
Firefox 57
Iteration:
1.28
Tracking Status
firefox57 --- fixed

People

(Reporter: liuche, Assigned: liuche)

References

Details

(Whiteboard: [MobileAS])

Attachments

(1 file)

In bug 1386906, I added the build flag for Pocket, but didn't actually DEFINE it from the config.
Assignee: nobody → liuche
Comment on attachment 8900544 [details]
Bug 1393321 - Actually define MOZ_ANDROID_POCKET.

https://reviewboard.mozilla.org/r/171940/#review177162

I'm no build master but I checked over this locally with liuche and it seems reasonable.

The keys were not defined in AppConstants because we `#ifdef MOZ_POCKET_ANDROID` and apparently it was not defined. It seems this magical incantation will define `MOZ_POCKET_ANDROID` for the rest of the build process. liuche ran it locally and it built successfully with the appropriate keys.

r+ w/ successful try run.
Attachment #8900544 - Flags: review?(michael.l.comella) → review+
Pushed by cliu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adff388db8bc
Actually define MOZ_ANDROID_POCKET. r=mcomella
https://hg.mozilla.org/mozilla-central/rev/adff388db8bc
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
No need to track - work was completed in the current iteration.
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.