Closed
Bug 1393321
Opened 8 years ago
Closed 8 years ago
Define MOZ_ANDROID_POCKET from config
Categories
(Firefox for Android Graveyard :: General, enhancement, P1)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
Firefox 57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: liuche, Assigned: liuche)
References
Details
(Whiteboard: [MobileAS])
Attachments
(1 file)
In bug 1386906, I added the build flag for Pocket, but didn't actually DEFINE it from the config.
| Comment hidden (mozreview-request) |
Assignee: nobody → liuche
|
||
Comment 2•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8900544 [details]
Bug 1393321 - Actually define MOZ_ANDROID_POCKET.
https://reviewboard.mozilla.org/r/171940/#review177162
I'm no build master but I checked over this locally with liuche and it seems reasonable.
The keys were not defined in AppConstants because we `#ifdef MOZ_POCKET_ANDROID` and apparently it was not defined. It seems this magical incantation will define `MOZ_POCKET_ANDROID` for the rest of the build process. liuche ran it locally and it built successfully with the appropriate keys.
r+ w/ successful try run.
Attachment #8900544 -
Flags: review?(michael.l.comella) → review+
Pushed by cliu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/adff388db8bc
Actually define MOZ_ANDROID_POCKET. r=mcomella
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
No need to track - work was completed in the current iteration.
tracking-fennec: ? → ---
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•