Add infrastructure to import Credit Cards from Chrome
Categories
(Firefox :: Migration, defect, P3)
Tracking
()
People
(Reporter: chsiang, Assigned: zcharris)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [form autofill])
User Story
We would like to help Chromes users immediately feel like home when they migrate to Firefox by giving them an option to import all their autofill data. [Success Criteria] In the import wizard, add an option for Chrome users to import Saved Addresses and Credit Cards
Attachments
(2 files)
37.45 KB,
image/png
|
Details | |
Bug 1393332 - Add infrastructure for importing payment methods from Chrome-based browsers r?mconley!
48 bytes,
text/x-phabricator-request
|
Details | Review |
No description provided.
Updated•6 years ago
|
Updated•6 years ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Comment 1•1 year ago
|
||
One thing we're going to want to do here is introduce a new resource type for credit cards, as this information is considered sensitive enough to not include it under the FORMDATA umbrella.
Comment 2•1 year ago
•
|
||
Let's start with the credit card importing, and then move on to addresses.
Here's what I'd start with:
- So the first step is to add a new value to resourceTypes here: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/MigrationUtils.sys.mjs#114-124 . Let's add a new
PAYMENT_METHODS
resource type to this list, with the value of0x0100
. - Next add a "payment_methods" mapping (lowercase) to https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/content/migration.js#24-32. Let's set the value to
"browser-data-payment-methods"
. That's going to come into play in the next step. - That value we just added is for the strings we're going to introduce in this step. Let's do the same as this: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/locales/en-US/browser/migration.ftl#162-165, but use
browser-data-payment-methods-checkbox
andbrowser-data-payment-methods-label
, and set the value for those two asPayment methods
- Next, we're going to clone
GetBookmarksResource
but call itGetPaymentMethodsResource
: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/ChromeProfileMigrator.sys.mjs#355-426 - Make sure the returned object
type
isMigrationUtils.resourceTypes.PAYMENT_METHODS
. Themigrate
function in there is going to do the work that you've proven out. We're going to do the SQLite query, decrypt the data. Let's get that far, and then we'll work on inserting those credit cards into the Firefox database.
Assignee | ||
Comment 3•10 months ago
|
||
r?mconley...
Updated•10 months ago
|
Updated•10 months ago
|
Comment 4•10 months ago
•
|
||
Quick update here - we're going to generalize a bit, and change the type from "CREDITCARDS" to "PAYMENT_METHODS". I've updated comment 2 to suit.
Updated•10 months ago
|
Updated•9 months ago
|
Updated•7 months ago
|
Updated•7 months ago
|
Comment 5•7 months ago
|
||
The UI will be added in a different bug, which I'll link to here shortly.
Comment 6•7 months ago
|
||
Ah, I forgot it was already filed - the UI will be added in bug 1826149.
Updated•7 months ago
|
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f7f2b8abcf6c Add infrastructure for importing payment methods from Chrome-based browsers r=mconley,fluent-reviewers,flod
Comment 8•7 months ago
|
||
Backed out for causing xpcshell failures on test_Chrome_formdata.js
Failure log: https://treeherder.mozilla.org/logviewer?job_id=415475949&repo=autoland&lineNumber=4815
Backout link: https://hg.mozilla.org/integration/autoland/rev/55608cb73889b742af7c22a62da300048606e894
Updated•7 months ago
|
Updated•7 months ago
|
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b18e7995e7cd Add infrastructure for importing payment methods from Chrome-based browsers r=mconley,fluent-reviewers,flod
Comment 10•7 months ago
|
||
Backed out for causing xpcshell failures on test_Chrome_credit_cards.js
Updated•7 months ago
|
Comment 11•7 months ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a3165d792ed7 Add infrastructure for importing payment methods from Chrome-based browsers r=mconley,fluent-reviewers,flod
Comment 12•7 months ago
|
||
bugherder |
Comment 13•6 months ago
|
||
Release Note Request (optional, but appreciated)
[Why is this notable]:
Users coming from other Chrome-based browsers will now be able to import credit card data saved in those old browsers.
[Affects Firefox for Android]:
No.
[Suggested wording]:
Migrating from another browser? Now you can bring over payment methods you've saved in Chrome-based browsers to Firefox.
[Links (documentation, blog post, etc)]:
N/A.
Comment 14•6 months ago
|
||
Thanks, added to Fx115 the Nightly release notes. Keeping the relnote? flag open to keep it on the radar for inclusion in our final release notes.
Updated•5 months ago
|
Description
•