Open Bug 1393332 Opened 6 years ago Updated 28 days ago

Import Credit Cards from Chrome

Categories

(Firefox :: Migration, defect, P3)

Product:
Firefox
Component:
Migration
Type:
defect

Tracking

()

People

(Reporter: chsiang, Assigned: zcharris)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [form autofill])

User Story

We would like to help Chromes users immediately feel like home when they migrate to Firefox by giving them an option to import all their autofill data.

[Success Criteria]
In the import wizard, add an option for Chrome users to import Saved Addresses and Credit Cards

Attachments

(2 files)

image.png
37.45 KB, image/png
Details
WIP: Bug 1393332 - Import Credit Cards from Chrome r?mconley
48 bytes, text/x-phabricator-request
Details | Review
Attached image image.png — 
      No description provided.
User Story: (updated)
Component: Form Manager → Migration
Product: Toolkit → Firefox
Whiteboard: [form autofill]
Blocks: fx-form-autofill
Priority: -- → P3
Severity: normal → S3
Assignee: nobody → zcharris

One thing we're going to want to do here is introduce a new resource type for credit cards, as this information is considered sensitive enough to not include it under the FORMDATA umbrella.

Let's start with the credit card importing, and then move on to addresses.

Here's what I'd start with:

  1. So the first step is to add a new value to resourceTypes here: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/MigrationUtils.sys.mjs#114-124 . Let's add a new PAYMENT_METHODS resource type to this list, with the value of 0x0100.
  2. Next add a "payment_methods" mapping (lowercase) to https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/content/migration.js#24-32. Let's set the value to "browser-data-payment-methods". That's going to come into play in the next step.
  3. That value we just added is for the strings we're going to introduce in this step. Let's do the same as this: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/locales/en-US/browser/migration.ftl#162-165, but use browser-data-payment-methods-checkbox and browser-data-payment-methods-label, and set the value for those two as Payment methods
  4. Next, we're going to clone GetBookmarksResource but call it GetPaymentMethodsResource: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/ChromeProfileMigrator.sys.mjs#355-426
  5. Make sure the returned object type is MigrationUtils.resourceTypes.PAYMENT_METHODS. The migrate function in there is going to do the work that you've proven out. We're going to do the SQLite query, decrypt the data. Let's get that far, and then we'll work on inserting those credit cards into the Firefox database.

r?mconley...

Attachment #9315182 - Attachment description: WIP: Bug 1393332 - Import Saved Addresses and Credit Cards from Chrome → WIP: Bug 1393332 - Import Saved Addresses and Credit Cards from Chrome r?mconley...
Attachment #9315182 - Attachment description: WIP: Bug 1393332 - Import Saved Addresses and Credit Cards from Chrome r?mconley... → Bug 1393332 - Import Saved Addresses and Credit Cards from Chrome r?mconley

Quick update here - we're going to generalize a bit, and change the type from "CREDITCARDS" to "PAYMENT_METHODS". I've updated comment 2 to suit.

Summary: Import Saved Addresses and Credit Cards from Chrome → Import Credit Cards from Chrome
Attachment #9315182 - Attachment description: Bug 1393332 - Import Saved Addresses and Credit Cards from Chrome r?mconley → WIP: Bug 1393332 - Import Credit Cards from Chrome r?mconley
You need to log in before you can comment on or make changes to this bug.