Open
Bug 1393332
Opened 6 years ago
Updated 28 days ago
Import Credit Cards from Chrome
Categories
(Firefox :: Migration, defect, P3)
Firefox
Migration
Tracking
()
NEW
People
(Reporter: chsiang, Assigned: zcharris)
References
(Blocks 2 open bugs)
Details
(Whiteboard: [form autofill])
User Story
We would like to help Chromes users immediately feel like home when they migrate to Firefox by giving them an option to import all their autofill data. [Success Criteria] In the import wizard, add an option for Chrome users to import Saved Addresses and Credit Cards
Attachments
(2 files)
No description provided.
Updated•6 years ago
|
Component: Form Manager → Migration
Product: Toolkit → Firefox
Whiteboard: [form autofill]
Updated•6 years ago
|
Blocks: fx-form-autofill
Priority: -- → P3
Updated•5 months ago
|
Severity: normal → S3
Updated•5 months ago
|
Assignee: nobody → zcharris
Comment 1•4 months ago
|
||
One thing we're going to want to do here is introduce a new resource type for credit cards, as this information is considered sensitive enough to not include it under the FORMDATA umbrella.
Comment 2•3 months ago
•
|
||
Let's start with the credit card importing, and then move on to addresses.
Here's what I'd start with:
- So the first step is to add a new value to resourceTypes here: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/MigrationUtils.sys.mjs#114-124 . Let's add a new
PAYMENT_METHODS
resource type to this list, with the value of0x0100
. - Next add a "payment_methods" mapping (lowercase) to https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/content/migration.js#24-32. Let's set the value to
"browser-data-payment-methods"
. That's going to come into play in the next step. - That value we just added is for the strings we're going to introduce in this step. Let's do the same as this: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/locales/en-US/browser/migration.ftl#162-165, but use
browser-data-payment-methods-checkbox
andbrowser-data-payment-methods-label
, and set the value for those two asPayment methods
- Next, we're going to clone
GetBookmarksResource
but call itGetPaymentMethodsResource
: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/ChromeProfileMigrator.sys.mjs#355-426 - Make sure the returned object
type
isMigrationUtils.resourceTypes.PAYMENT_METHODS
. Themigrate
function in there is going to do the work that you've proven out. We're going to do the SQLite query, decrypt the data. Let's get that far, and then we'll work on inserting those credit cards into the Firefox database.
Assignee | ||
Comment 3•2 months ago
|
||
r?mconley...
Updated•2 months ago
|
Attachment #9315182 -
Attachment description: WIP: Bug 1393332 - Import Saved Addresses and Credit Cards from Chrome → WIP: Bug 1393332 - Import Saved Addresses and Credit Cards from Chrome r?mconley...
Updated•1 month ago
|
Attachment #9315182 -
Attachment description: WIP: Bug 1393332 - Import Saved Addresses and Credit Cards from Chrome r?mconley... → Bug 1393332 - Import Saved Addresses and Credit Cards from Chrome r?mconley
Comment 4•1 month ago
•
|
||
Quick update here - we're going to generalize a bit, and change the type from "CREDITCARDS" to "PAYMENT_METHODS". I've updated comment 2 to suit.
Updated•1 month ago
|
Summary: Import Saved Addresses and Credit Cards from Chrome → Import Credit Cards from Chrome
Updated•28 days ago
|
Attachment #9315182 -
Attachment description: Bug 1393332 - Import Saved Addresses and Credit Cards from Chrome r?mconley → WIP: Bug 1393332 - Import Credit Cards from Chrome r?mconley
You need to log in
before you can comment on or make changes to this bug.
Description
•