1393332 - Add infrastructure to import Credit Cards from Chrome

Status: RESOLVED FIXED

(Firefox :: Migration, defect, P3)

Description

[chsiang]

Attachment: image.png

Comment 1

[Mike Conley (:mconley) (:⚙️)]

One thing we're going to want to do here is introduce a new resource type for credit cards, as this information is considered sensitive enough to not include it under the FORMDATA umbrella.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Let's start with the credit card importing, and then move on to addresses.

Here's what I'd start with:

1. So the first step is to add a new value to resourceTypes here: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/MigrationUtils.sys.mjs#114-124 . Let's add a new PAYMENT_METHODS resource type to this list, with the value of 0x0100.
2. Next add a "payment_methods" mapping (lowercase) to https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/content/migration.js#24-32. Let's set the value to "browser-data-payment-methods". That's going to come into play in the next step.
3. That value we just added is for the strings we're going to introduce in this step. Let's do the same as this: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/locales/en-US/browser/migration.ftl#162-165, but use browser-data-payment-methods-checkbox and browser-data-payment-methods-label, and set the value for those two as Payment methods
4. Next, we're going to clone GetBookmarksResource but call it GetPaymentMethodsResource: https://searchfox.org/mozilla-central/rev/f40d29a11f2eb4685256b59934e637012ea6fb78/browser/components/migration/ChromeProfileMigrator.sys.mjs#355-426
5. Make sure the returned object type is MigrationUtils.resourceTypes.PAYMENT_METHODS. The migrate function in there is going to do the work that you've proven out. We're going to do the SQLite query, decrypt the data. Let's get that far, and then we'll work on inserting those credit cards into the Firefox database.

Comment 3

[Zach Harris]

Attachment: Bug 1393332 - Add infrastructure for importing payment methods from Chrome-based browsers r?mconley!

r?mconley...

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Quick update here - we're going to generalize a bit, and change the type from "CREDITCARDS" to "PAYMENT_METHODS". I've updated comment 2 to suit.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

The UI will be added in a different bug, which I'll link to here shortly.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Ah, I forgot it was already filed - the UI will be added in bug 1826149.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f7f2b8abcf6c
Add infrastructure for importing payment methods from Chrome-based browsers r=mconley,fluent-reviewers,flod

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for causing xpcshell failures on test_Chrome_formdata.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=f7f2b8abcf6c1d0a1fdca53eb4e413e75ba771b5&tochange=55608cb73889b742af7c22a62da300048606e894&searchStr=xpc&selectedTaskRun=RJRYY6zgR1S4hwwfu8cL5A.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=415475949&repo=autoland&lineNumber=4815

Backout link: https://hg.mozilla.org/integration/autoland/rev/55608cb73889b742af7c22a62da300048606e894

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b18e7995e7cd
Add infrastructure for importing payment methods from Chrome-based browsers r=mconley,fluent-reviewers,flod

Comment 10

[Norisz Fay [:noriszfay]]

Backed out for causing xpcshell failures on test_Chrome_credit_cards.js

Backout link

Push with failures

Failure log

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3165d792ed7
Add infrastructure for importing payment methods from Chrome-based browsers r=mconley,fluent-reviewers,flod

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a3165d792ed7

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Release Note Request (optional, but appreciated)
[Why is this notable]:

Users coming from other Chrome-based browsers will now be able to import credit card data saved in those old browsers.

[Affects Firefox for Android]:

No.

[Suggested wording]:

Migrating from another browser? Now you can bring over payment methods you've saved in Chrome-based browsers to Firefox.

[Links (documentation, blog post, etc)]:

N/A.

Comment 14

[Donal Meehan [:dmeehan]]

Thanks, added to Fx115 the Nightly release notes. Keeping the relnote? flag open to keep it on the radar for inclusion in our final release notes.