Closed Bug 1393337 Opened 2 years ago Closed 2 years ago

Get rid of nsIEditRules

Categories

(Core :: DOM: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla59
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

Attachments

(1 file, 1 obsolete file)

nsIEditRules is an abstract class of TextEditRules and HTMLEditRules. However, HTMLEditRules is a subclass of TextEditRules and nsIEditRules is not referred by any other modules. So, we can just get rid of the interface and could make some methods of them non-virtual.
Priority: -- → P3
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Comment on attachment 8938327 [details]
Bug 1393337 - Don't try to remove whitespaces in WSRunObject::ConvertToNBSP() when the text node is changed by mutation observer

https://reviewboard.mozilla.org/r/209054/#review215006

Is this bug 1425997?
Oh, sorry I posted different bug's patch here.
Attachment #8938327 - Attachment is obsolete: true
Attachment #8938327 - Flags: review?(m_kato)
Comment on attachment 8938558 [details]
Bug 1393337 - Get rid of nsIEditRules

https://reviewboard.mozilla.org/r/209196/#review215090

As deCom, it is OK.  But I think that some members (such as mTimer) in TextEditRules should be private. Or, we creates EditRules class and HTMLEditRules shouldn't be inheritance class of TextEditRules because some fuctions is only Text mode such as password.
Attachment #8938558 - Flags: review?(m_kato) → review+
Comment on attachment 8938558 [details]
Bug 1393337 - Get rid of nsIEditRules

https://reviewboard.mozilla.org/r/209196/#review215090

Yeah, looks like that we should clean them up in some follow up bugs.
https://hg.mozilla.org/mozilla-central/rev/f4fdf6c12d5f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Too late for FF58. Mark 58 won't fix.
You need to log in before you can comment on or make changes to this bug.