All users were logged out of Bugzilla on October 13th, 2018

Get rid of nsIEditRules

RESOLVED FIXED in Firefox 59

Status

()

P3
normal
RESOLVED FIXED
a year ago
10 months ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla59
Points:
---

Firefox Tracking Flags

(firefox57 wontfix, firefox58 wontfix, firefox59 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

nsIEditRules is an abstract class of TextEditRules and HTMLEditRules. However, HTMLEditRules is a subclass of TextEditRules and nsIEditRules is not referred by any other modules. So, we can just get rid of the interface and could make some methods of them non-virtual.
Priority: -- → P3
(Assignee)

Updated

10 months ago
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)

Comment 5

10 months ago
mozreview-review
Comment on attachment 8938327 [details]
Bug 1393337 - Don't try to remove whitespaces in WSRunObject::ConvertToNBSP() when the text node is changed by mutation observer

https://reviewboard.mozilla.org/r/209054/#review215006

Is this bug 1425997?
Oh, sorry I posted different bug's patch here.
(Assignee)

Updated

10 months ago
Attachment #8938327 - Attachment is obsolete: true
Attachment #8938327 - Flags: review?(m_kato)
Comment hidden (mozreview-request)

Comment 8

10 months ago
mozreview-review
Comment on attachment 8938558 [details]
Bug 1393337 - Get rid of nsIEditRules

https://reviewboard.mozilla.org/r/209196/#review215090

As deCom, it is OK.  But I think that some members (such as mTimer) in TextEditRules should be private. Or, we creates EditRules class and HTMLEditRules shouldn't be inheritance class of TextEditRules because some fuctions is only Text mode such as password.
Attachment #8938558 - Flags: review?(m_kato) → review+
(Assignee)

Comment 9

10 months ago
mozreview-review-reply
Comment on attachment 8938558 [details]
Bug 1393337 - Get rid of nsIEditRules

https://reviewboard.mozilla.org/r/209196/#review215090

Yeah, looks like that we should clean them up in some follow up bugs.

Comment 10

10 months ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/f4fdf6c12d5f
Get rid of nsIEditRules r=m_kato

Comment 11

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f4fdf6c12d5f
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox59: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla59

Comment 12

10 months ago
Too late for FF58. Mark 58 won't fix.
status-firefox57: affected → wontfix
status-firefox58: --- → wontfix
You need to log in before you can comment on or make changes to this bug.