Closed Bug 1393337 Opened 2 years ago Closed 2 years ago
Get rid of ns
nsIEditRules is an abstract class of TextEditRules and HTMLEditRules. However, HTMLEditRules is a subclass of TextEditRules and nsIEditRules is not referred by any other modules. So, we can just get rid of the interface and could make some methods of them non-virtual.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Comment on attachment 8938327 [details] Bug 1393337 - Don't try to remove whitespaces in WSRunObject::ConvertToNBSP() when the text node is changed by mutation observer https://reviewboard.mozilla.org/r/209054/#review215006 Is this bug 1425997?
Oh, sorry I posted different bug's patch here.
Comment on attachment 8938558 [details] Bug 1393337 - Get rid of nsIEditRules https://reviewboard.mozilla.org/r/209196/#review215090 As deCom, it is OK. But I think that some members (such as mTimer) in TextEditRules should be private. Or, we creates EditRules class and HTMLEditRules shouldn't be inheritance class of TextEditRules because some fuctions is only Text mode such as password.
Attachment #8938558 - Flags: review?(m_kato) → review+
Comment on attachment 8938558 [details] Bug 1393337 - Get rid of nsIEditRules https://reviewboard.mozilla.org/r/209196/#review215090 Yeah, looks like that we should clean them up in some follow up bugs.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/f4fdf6c12d5f Get rid of nsIEditRules r=m_kato
Too late for FF58. Mark 58 won't fix.
You need to log in before you can comment on or make changes to this bug.