1393354 - Pressed link text color should match the spec

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Hani Yacoub, Desktop QA]

Attachment: pressed link text.png

[Affected versions]: 
Nightly 57.0a1

[Affected platforms]:
Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Launch Firefox.
2. Go to "about:preferences".
3. Press on any "Learn more" link.

[Expected result]:
Pressed link text color should be blue.

[Actual result]:
Pressed link text color is orange.

Comment 1

[Evan Tseng [:evanxd]]

Attachment: link-is-blue.png

Hi Hani,

I could not reproduce this bug. The link is build. You could see that in the attachment.

Thank you.

Comment 2

[Evan Tseng [:evanxd]]

Hi Hani,

Sorry, I misunderstood previously. I understand what what we should fix now.

Thank you.

Comment 3

[Evan Tseng [:evanxd]]

Attachment: Bug 1393354 - Update the color code of in-content link's normal, hover, and active stages to match Photon visual spec.

Review commit: https://reviewboard.mozilla.org/r/172614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172614/

Comment 4

[Evan Tseng [:evanxd]]

Comment on attachment 8901142 [details]
Bug 1393354 - Update the color code of in-content link's normal, hover, and active stages to match Photon visual spec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172614/diff/1-2/

Comment 5

[Evan Tseng [:evanxd]]

Hi Mike,

Could you help review the patch?

And color color spec info in mentioned in this page[1].

Thank you.

[1]: https://mozilla.invisionapp.com/share/X8BGCX9PD#/screens/244683136

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8901142 [details]
Bug 1393354 - Update the color code of in-content link's normal, hover, and active stages to match Photon visual spec.

https://reviewboard.mozilla.org/r/172614/#review178020

Thanks, looks good, and matches spec - but didn't apply cleanly when I tested it locally. You'll likely need to rebase.

Comment 7

[Evan Tseng [:evanxd]]

Comment on attachment 8901142 [details]
Bug 1393354 - Update the color code of in-content link's normal, hover, and active stages to match Photon visual spec.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172614/diff/2-3/

Comment 8

[Evan Tseng [:evanxd]]

Hi Mike,

Thank you for the review.

And I rebased the patch.

Let's land it.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9e5463eb98bc
Update the color code of in-content link's normal, hover, and active stages to match Photon visual spec. r=mconley

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9e5463eb98bc

Comment 11

[Hani Yacoub, Desktop QA]

Build ID: 20170829100404
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.