Closed Bug 1393354 Opened 3 years ago Closed 3 years ago
Pressed link text color should match the spec
54.06 KB, image/png
61.01 KB, image/png
Bug 1393354 - Update the color code of in-content link's normal, hover, and active stages to match Photon visual spec.
59 bytes, text/x-review-board-request
[Affected versions]: Nightly 57.0a1 [Affected platforms]: Platforms: Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64. [Steps to reproduce]: 1. Launch Firefox. 2. Go to "about:preferences". 3. Press on any "Learn more" link. [Expected result]: Pressed link text color should be blue. [Actual result]: Pressed link text color is orange.
Priority: -- → P2
QA Contact: hani.yacoub
Whiteboard: [photon-preference][triage] → [photon-preference]
Hi Hani, I could not reproduce this bug. The link is build. You could see that in the attachment. Thank you.
Hi Hani, Sorry, I misunderstood previously. I understand what what we should fix now. Thank you.
Assignee: nobody → evan
Status: NEW → ASSIGNED
Priority: P2 → P1
Hi Mike, Could you help review the patch? And color color spec info in mentioned in this page. Thank you. : https://mozilla.invisionapp.com/share/X8BGCX9PD#/screens/244683136
Comment on attachment 8901142 [details] Bug 1393354 - Update the color code of in-content link's normal, hover, and active stages to match Photon visual spec. https://reviewboard.mozilla.org/r/172614/#review178020 Thanks, looks good, and matches spec - but didn't apply cleanly when I tested it locally. You'll likely need to rebase.
Attachment #8901142 - Flags: review?(mconley) → review+
Hi Mike, Thank you for the review. And I rebased the patch. Let's land it.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/9e5463eb98bc Update the color code of in-content link's normal, hover, and active stages to match Photon visual spec. r=mconley
Build ID: 20170829100404 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0 Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
You need to log in before you can comment on or make changes to this bug.