1393385 - Update about:preferences category menu to match the spec

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Ricky Chien [:rickychien] (inactive)]

Visual spec has updated to reflect to Photon design consistency

https://mozilla.invisionapp.com/share/X8BGCX9PD#/screens/244683005_Navigation

Comment 1

[Ricky Chien [:rickychien] (inactive)]

See menu states overview for detailed visual changes.

Comment 2

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1393385 - Update about:preferences category menu to match the spec

Review commit: https://reviewboard.mozilla.org/r/172058/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172058/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8900655 [details]
Bug 1393385 - Update about:preferences category menu to match the spec

https://reviewboard.mozilla.org/r/172058/#review177390

r=me with the following changes.

Using :hover:active instead of :active is better because it will only show the :active styling while the user is hovering over the item. Otherwise if a user presses down on their mouse while over the item, then mouses away while still pressing their mouse button the item would still appear pressed even though releasing the mouse button will not activate the button.

::: toolkit/themes/shared/in-content/common.inc.css:667
(Diff revision 1)
>  *|*.category:hover {
> -  background-color: var(--in-content-category-hover);
> +  background-color: var(--in-content-category-background-hover);
> +  border-radius: 2px;
> +}
> +
> +*|*.category:active {

*|*.category:hover:active

::: toolkit/themes/shared/in-content/common.inc.css:682
(Diff revision 1)
> +*|*.category[selected]:active,
> +*|*.category.selected:active {

*|*.category[selected]:hover:active,
*|*.category.selected:hover:active

Comment 4

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8900655 [details]
Bug 1393385 - Update about:preferences category menu to match the spec

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172058/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3bbd8e25df3d
Update about:preferences category menu to match the spec r=jaws

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3bbd8e25df3d

Comment 7

[Hani Yacoub, Desktop QA]

Build ID: 20170903220032
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64 and on Mac OS X 10.12.

I'll verify this bug on Ubuntu 16.04 only after bug 1392532 will be fixed.

Comment 8

[Hani Yacoub, Desktop QA]

Build ID: 201709055220108
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Ubuntu 16.04 x64.