Closed Bug 1393395 Opened 3 years ago Closed 3 years ago

Poor contrast of DOMContentLoaded waterfall tick in dark theme

Categories

(DevTools :: Netmonitor, enhancement, P3)

enhancement

Tracking

(firefox57 fixed)

RESOLVED FIXED
Firefox 57
Tracking Status
firefox57 --- fixed

People

(Reporter: ntim, Assigned: jdescottes)

References

Details

Attachments

(1 file)

See bug 1354472 comment 11.

I would be fine with a fix that does what bug 1354472 comment 7 suggests.
Component: Developer Tools: Inspector → Developer Tools: Netmonitor
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Priority: -- → P3
Tim: Hi! Do you want me to forward the r? to someone else if you don't have the bandwidth to do it?
Flags: needinfo?(ntim.bugs)
Comment on attachment 8900933 [details]
Bug 1393395 - synchronize network monitor tick marker colors with font colors;

https://reviewboard.mozilla.org/r/172374/#review179218

Looks good to me! Sorry it took me a bit of time to look at this.
Attachment #8900933 - Flags: review?(ntim.bugs) → review+
Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/34ee6e678b19
synchronize network monitor tick marker colors with font colors;r=ntim
https://hg.mozilla.org/mozilla-central/rev/34ee6e678b19
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.