1393395 - Poor contrast of DOMContentLoaded waterfall tick in dark theme

Status: RESOLVED FIXED

(DevTools :: Netmonitor, enhancement, P3)

Description

[Tim Nguyen :ntim]

See bug 1354472 comment 11.

I would be fine with a fix that does what bug 1354472 comment 7 suggests.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1393395 - synchronize network monitor tick marker colors with font colors;

Review commit: https://reviewboard.mozilla.org/r/172374/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172374/

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 8900933 [details]
Bug 1393395 - synchronize network monitor tick marker colors with font colors;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172374/diff/1-2/

Comment 3

[Julian Descottes [:jdescottes]]

Tim: Hi! Do you want me to forward the r? to someone else if you don't have the bandwidth to do it?

Comment 4

[Tim Nguyen :ntim]

Comment on attachment 8900933 [details]
Bug 1393395 - synchronize network monitor tick marker colors with font colors;

https://reviewboard.mozilla.org/r/172374/#review179218

Looks good to me! Sorry it took me a bit of time to look at this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34ee6e678b19
synchronize network monitor tick marker colors with font colors;r=ntim

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/34ee6e678b19