1393417 - Android and iOS icons aren't displayed with high contrast themes

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Hani Yacoub, Desktop QA]

Attachment: android and iOS icons.png

[Affected versions]: 
Nightly 57.0a1

[Affected platforms]:
Platforms: Windows 10 x 64 and Ubuntu 16.04 x64.

[Steps to reproduce]:
1. Launch Firefox.
2. Go to "about:preferences".
3. Go to Firefox Account.

[Expected result]:
Android and iOS icons should be displayed.

[Actual result]:
Android and iOS icons aren't displayed with high contrast themes

Comment 1

[Ricky Chien [:rickychien] (inactive)]

Attachment: Bug 1393417 - Make Preferences Android and iOS icons highlight in high contrast themes

Review commit: https://reviewboard.mozilla.org/r/184438/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/184438/

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 8913050 [details]
Bug 1393417 - Make Preferences Android and iOS icons highlight in high contrast themes

https://reviewboard.mozilla.org/r/184438/#review189676

::: browser/themes/shared/incontentprefs/preferences.inc.css:584
(Diff revision 1)
>    margin-inline-start: 2px;
>    margin-inline-end: 4px;
>    width: 20px;
>    height: 20px;
>    vertical-align: text-bottom;
> +  -moz-context-properties: fill, stroke;

It looks like you're not using stroke, so you shouldn't set it here.

Comment 3

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8913050 [details]
Bug 1393417 - Make Preferences Android and iOS icons highlight in high contrast themes

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/184438/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/75620646ccb8
Make Preferences Android and iOS icons highlight in high contrast themes r=dao

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/75620646ccb8

Comment 6

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8913050 [details]
Bug 1393417 - Make Preferences Android and iOS icons highlight in high contrast themes

Approval Request Comment
[Feature/Bug causing the regression]:
[User impact if declined]: minor visual issue only in Windows high contrast mode
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: see description
[List of other uplifts needed for the feature/fix]: no
[Is the change risky?]: minor
[Why is the change risky/not risky?]: minor visual issue
[String changes made/needed]: none

Comment 7

[Hani Yacoub, Desktop QA]

Build ID: 20171001220301
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:58.0) Gecko/20100101 Firefox/58.0

Verified as fixed on Firefox Nightly 58.0a1 on Windows 10 x 64, Windows 7 x32 and Ubuntu 16.04 x64.

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8913050 [details]
Bug 1393417 - Make Preferences Android and iOS icons highlight in high contrast themes

Fix a new visual regression, taking it
Should be in 57b5

Comment 9

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-beta/rev/2445f6df733d

Comment 10

[Hani Yacoub, Desktop QA]

Build ID: 20171002181526
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Beta 57.0b5 on Windows 10 x 64, Windows 7 x32 and Ubuntu 16.04 x64.