Open Bug 1393421 Opened 8 years ago Updated 2 years ago

Clean up pocket-animation.svg

Categories

(Firefox :: Pocket, enhancement, P4)

enhancement

Tracking

()

Tracking Status
firefox57 --- affected

People

(Reporter: jaws, Unassigned)

References

(Blocks 1 open bug)

Details

(Whiteboard: [reserve-photon-animation])

Some comments from bug 1386029, (In reply to Jonathan Watt [:jwatt] from comment #10) > BTW pocket-animation.svg has a lot of unnecessary overhead. > > * all the filters are identical - we could just use one > > * there's no need to put the <filter> in a <defs> > > * in fact it looks like the filter is just about coloring - it > could be replaced by passing in a context-stroke value as a second > color which would render much faster and with less CPU work than a > filter > > * all the <svg> (other than the root) and <g> elements are > unnecessary > > * the 'transform' attributes could be applied to the path data > statically to avoid having to transform all the paths at runtime > which is more expensive (In reply to Jonathan Watt [:jwatt] from comment #11) > (In reply to Jonathan Watt [:jwatt] from comment #10) > > * all the <svg> (other than the root) and <g> elements are > > unnecessary > > To be clear the 'x' attributes on the inner-<svg> elements would need to be > propagated into the path data.
Flags: qe-verify-
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.