1393458 - "E_First_Run" and "E_Second_Run" is not triggered after launching Firefox a second time

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P1)

Description

[Simon Basca [:SimonB]]

Build: master bbaa76973a
Device: iPad Air 2
iOS: 10.3.3

Steps to reproduce;
1. Clean install Firefox
2. Launch Firefox for the first time
3. Close Firefox
4. Launch Firefox a second time
5. Check the Leanplum event trail

Actual results:
- App is correctly launched but the event "E_Second_Run" is not displayed in the event trail.

Expected results:
- "E_Second_Run" should be displayed in the event trail when launching Firefox for the second time.

Comment 1

[:sdaswani]

This is probably a race condition - we call first and second run very soon after intializing LP, so when we previously tested we may have been getting lucky and seeing the first run event. This needs to be wrapped in a onStartResponse call like the pocket and focus events.

Comment 2

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 4

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/5d9a0cc11573dea22633af8113aa55d471fd94a5

Comment 5

[Farhan Patel [:farhan]]

uplifted to 8.x as well.

Comment 6

[Farhan Patel [:farhan]]

uplifted to 9.x too

Comment 7

[Simon Basca [:SimonB]]

Verifying as fix on master 631c2932d3c81e. The events are firing correctly on the first and second run.

Comment 8

[Simon Basca [:SimonB]]

Verifying as fix on beta 8.3(5817).