1393466 - "E_Opened_New_Tab" not triggered when opening a new tab via menu from Tabs Tray

Status: VERIFIED FIXED

(Firefox for iOS :: General, defect, P2)

Description

[Simon Basca [:SimonB]]

Build: master bbaa76973a
Device: iPad Air 2
iOS: 10.3.3

Steps to reproduce;
1. Launch Firefox 
2. Go to Tabs Tray by tapping on the counter button
3. Open the menu
4. Tap the "New Tab" button 
5. Check the Leanplum event trail

Actual results:
- The tab is correctly opened but the "E_Opened_New_Tab" is not displayed in the event trail.

Expected results:
- "E_Opened_New_Tab" should be displayed in the event trail when opening a new tab.

Comment 1

[:sdaswani]

I can't reproduce this with the latest TestFlight version (8.3). Can you try with that version and see if you can reproduce it?

Comment 2

[Simon Basca [:SimonB]]

Re-tested with the latest master 7316eee29ce5fb and after discussing with Susheel we concluded that this bug is valid. 

The entry point that's not triggering the "E_Opened_New_Tab" event can be seen in the video: https://www.youtube.com/watch?v=29f0uGNc6rM

Comment 3

[:sdaswani]

(In reply to Simon Basca [:SimonB] from comment #2)
> Re-tested with the latest master 7316eee29ce5fb and after discussing with
> Susheel we concluded that this bug is valid. 
> 
> The entry point that's not triggering the "E_Opened_New_Tab" event can be
> seen in the video: https://www.youtube.com/watch?v=29f0uGNc6rM

Sorry I missed this - I saw the big + button on the bottom left and I tested that and it works.

Comment 4

[Farhan Patel [:farhan]]

master https://github.com/mozilla-mobile/firefox-ios/commit/4ebc358742008f962fc728668dea6a2973267841

Comment 5

[Farhan Patel [:farhan]]

uplifted to v8.x and v9.x

Comment 6

[Simon Basca [:SimonB]]

Verifying as fix on master b259426ff1a5a5.

Comment 7

[Simon Basca [:SimonB]]

Verifying as fix on beta 8.3(5817).