Closed
Bug 1393498
Opened 7 years ago
Closed 7 years ago
gcc throws noreturn warning about stub_BaseThreadInitThunk in WindowsDllBlocklist.cpp
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
Details
(Whiteboard: [tor])
Attachments
(1 file)
The pointer to stub_BaseThreadInitThunk is not marked MOZ_NORETURN so gcc throws a warning when it is called in a MOZ_NORETURN function.
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•7 years ago
|
||
Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7c5475a142da62b27434c8019545d78902c60e0 (Build will fail but the warning should be gone.)
Comment on attachment 8900794 [details] Bug 1393498 Mark the stub_BaseThreadInitThunk as MOZ_NORETURN to silence a warning about a noreturn function not returning https://reviewboard.mozilla.org/r/172230/#review177520 Would it be better to stick MOZ_NORETURN on the typedef? I'm fine either way.
Attachment #8900794 -
Flags: review?(dmajor) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/0df56be60d07 Mark the stub_BaseThreadInitThunk as MOZ_NORETURN to silence a warning about a noreturn function not returning r=dmajor
Keywords: checkin-needed
I had to back this out for Windows build failures like https://treeherder.mozilla.org/logviewer.html#?job_id=125645448&repo=autoland
Flags: needinfo?(tom)
| Comment hidden (mozreview-request) |
Backout by kwierso@gmail.com: https://hg.mozilla.org/integration/autoland/rev/88dfc4e305fb Backed out changeset 0df56be60d07 for windows build failures a=backout
|
|
Assignee | |
Comment 8•7 years ago
|
||
New Try Run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=557f76305e1487dce26ded7a6ac08427537c9511
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 10•7 years ago
|
||
This try run puts it on the typedef: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf271185a0479cd5b406e837fda5693b2feaab60
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 12•7 years ago
|
||
Okay https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf271185a0479cd5b406e837fda5693b2feaab60&selectedJob=125666481 shows a successful run with the attribute on the typedef. I cleaned up the patch and think it is ready for re-review and merge.
Flags: needinfo?(tom) → needinfo?(dmajor)
|
||
Comment 13•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8900794 [details] Bug 1393498 Mark the stub_BaseThreadInitThunk as MOZ_NORETURN to silence a warning about a noreturn function not returning https://reviewboard.mozilla.org/r/172230/#review177638
|
|
||
Comment 14•7 years ago
|
||
I am surprised that the attribute goes "on the outside", rather than next to __fastcall, but as long as the compiler isn't complaining, ship it!
Flags: needinfo?(dmajor)
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
|
||
Comment 15•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/d44d3fae6125 Mark the stub_BaseThreadInitThunk as MOZ_NORETURN to silence a warning about a noreturn function not returning r=dmajor
Keywords: checkin-needed
|
||
Comment 16•7 years ago
|
||
Backed out for bustage. Please provide a link to a green Try push with the next checkin-needed request. https://hg.mozilla.org/integration/autoland/rev/9ed004b33828 https://treeherder.mozilla.org/logviewer.html#?job_id=125717808&repo=autoland
Flags: needinfo?(tom)
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 18•7 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #16) > Backed out for bustage. Please provide a link to a green Try push with the > next checkin-needed request. Sorry, it busts in debug but not in opt (and I had only run opt in Comment 12). Extensive try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1e66398566590e496399f4c87118ed62ff27380 dmajor: I fixed this with a new MOZ_ attribute so I'm going to ask you to re-review.
|
|
Assignee | |
Comment 19•7 years ago
|
||
Trychooser told me about a platform TC throws an error about. Hopefully this one works: https://treeherder.mozilla.org/#/jobs?repo=try&revision=086706e1a7995c0058cb13a91f32ad0a5f8de86e
Flags: needinfo?(tom)
|
|
Assignee | |
Updated•7 years ago
|
Flags: needinfo?(dmajor)
Attachment #8900794 -
Flags: review?(nfroyd)
|
|
||
Comment 20•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8900794 [details] Bug 1393498 Mark the stub_BaseThreadInitThunk as MOZ_NORETURN to silence a warning about a noreturn function not returning https://reviewboard.mozilla.org/r/172230/#review179020
Attachment #8900794 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Updated•7 years ago
|
Keywords: checkin-needed
|
|
||
Comment 21•7 years ago
|
||
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1499dc6c1769 Mark the stub_BaseThreadInitThunk as MOZ_NORETURN to silence a warning about a noreturn function not returning r=dmajor,froydnj
Keywords: checkin-needed
|
|
||
Comment 22•7 years ago
|
||
Pushed by kwierso@gmail.com: https://hg.mozilla.org/mozilla-central/rev/defa8a301a0a Mark the stub_BaseThreadInitThunk as MOZ_NORETURN to silence a warning about a noreturn function not returning r=dmajor,froydnj
|
||
Comment 23•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/defa8a301a0a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•