1393536 - Fix Unused Variable Warnings in widget/

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=379f8cad988dfbc119ea264127e8f42fe5e51934

(Build will fail but the warnings should be gone)

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1393536 Clean up unused variables in widget/

Review commit: https://reviewboard.mozilla.org/r/172278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172278/

Comment 3

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8900835 [details]
Bug 1393536 Clean up unused variables in widget/

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172278/diff/1-2/

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Full try run to be safe:  https://treeherder.mozilla.org/#/jobs?repo=try&revision=051676530cdb0c7258375439726c50c16fd6191c

Comment 5

[Jim Mathies [:jimm]]

Comment on attachment 8900835 [details]
Bug 1393536 Clean up unused variables in widget/

https://reviewboard.mozilla.org/r/172278/#review177992

::: widget/windows/GfxInfo.cpp:602
(Diff revision 2)
>        GetProcAddress(dxgiModule, "CreateDXGIFactory");
>  
>      if (createDXGIFactory) {
>        RefPtr<IDXGIFactory> factory = nullptr;
> -      HRESULT hrf = createDXGIFactory(__uuidof(IDXGIFactory),
> +      createDXGIFactory(__uuidof(IDXGIFactory),
>                                        (void**)(&factory) );

nit - indentation fix needed

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8900835 [details]
Bug 1393536 Clean up unused variables in widget/

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172278/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e2566bf15934
Clean up unused variables in widget/ r=jimm

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e2566bf15934