Closed Bug 139355 Opened 24 years ago Closed 24 years ago

Update notifications is broken

Categories

(SeaMonkey :: UI Design, defect, P1)

Product:
SeaMonkey
Component:
UI Design
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla1.0

People

(Reporter: samir_bugzilla, Assigned: samir_bugzilla)

Details

(Whiteboard: [adt1])

Attachments

(1 file)

Patch v1.0.
1.13 KB, patch
jesup
: review+
alecf
: superreview+
jesup
: approval+
Details | Diff | Splinter Review
Getting the prefs service to use it for getLoclaizedUnicharPref() now causes an xpconnect exception in the getService() code. A simple change to the way we geta localized unichar pref in nsUserSettings.js as suggested by bnesse fixes this. Nominating for nsbeta1. This code is not shipped with mozilla. Only ships in ns since we have some more work to do on update notifications before we ship it in mozilla. But the code is in the mozilla tree since we will eventually ship it with mozilla as well.
Nominating. Recommending adt1 since update notifications is broken and QA can't even test it.
Status: NEW → ASSIGNED
Keywords: nsbeta1
QA Contact: paw → claudius
OS: Windows 2000 → All
Priority: -- → P1
Hardware: PC → All
Target Milestone: --- → mozilla1.0
Nav triage team: nsbeta1+, adt1
Keywords: nsbeta1 → nsbeta1+
Whiteboard: [adt1]
Attached patch Patch v1.0. — — Splinter Review
Use nsIPrefLocalzedString and getComplexValue().
r=bryner alecf, Please sr. Thanks!
Keywords: patch, review
Severity: normal → blocker
Comment on attachment 80696 [details] [diff] [review] Patch v1.0. sr=alecf
Attachment #80696 - Flags: superreview+
Seeking approval from adt to fix on branch. Mail sent to drivers even though this is not being shipped with mozilla yet (planned for post-1.0). It *is* being shipped with ns now.
Keywords: review → adt1.0.0
Checked in on trunk.
adt1.0.0+ (on ADT's behalf) approval for checkin into the 1.0 branch. Pls check this in today, then add the fixed1.0.0 keyword.
Keywords: adt1.0.0 → adt1.0.0+
Comment on attachment 80696 [details] [diff] [review] Patch v1.0. marking previous r=bryner a=rjesup@wgate.com for branch checkin
Attachment #80696 - Flags: review+
Attachment #80696 - Flags: approval+
Fix checked into branch.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Keywords: fixed1.0.0
Resolution: --- → FIXED
VERIFIED Fixed with 20020508 branch builds.
Keywords: fixed1.0.0 → verified1.0.0
v
Status: RESOLVED → VERIFIED
Product: Core → Mozilla Application Suite
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: