Open
Bug 1393553
Opened 7 years ago
Updated 2 years ago
firefox-55.0.2/toolkit/crashreporter/google-breakpad/src/common/mac/file_id.cc:64]: (style) Suspicious condition
Categories
(Toolkit :: Crash Reporting, defect, P5)
Tracking
()
UNCONFIRMED
People
(Reporter: dcb314, Unassigned)
Details
User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170613080647
Steps to reproduce:
firefox-55.0.2/toolkit/crashreporter/google-breakpad/src/common/mac/file_id.cc:64]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.
Source code is
while ((buffer_size = read(fd, buffer, buffer_size) > 0)) {
Maybe better code
while ((buffer_size = read(fd, buffer, buffer_size)) > 0) {
|
||
Updated•7 years ago
|
Component: Untriaged → Crash Reporting
Product: Firefox → Toolkit
|
||
Updated•5 years ago
|
Priority: -- → P5
|
||
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•