Closed Bug 1393577 Opened 2 years ago Closed 2 years ago

AS Context menu page domain scheme (domain.tld) leave out information, is inconsistent with top sites

Categories

(Firefox for Android :: Awesomescreen, enhancement, P1)

All
Android
enhancement

Tracking

()

RESOLVED FIXED
Firefox 57
Iteration:
1.29
Tracking Status
fennec + ---
firefox55 --- unaffected
firefox56 --- unaffected
firefox57 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

Details

(Whiteboard: [mobileAS])

Attachments

(4 files)

For blog.bugzilla.com in top sites, we show "blog.bugzilla".

In the context menu, we show, "bugzilla.com", which feels like it's leaving something out and inconsistent with top sites' "subdomain.domain". See the attached screenshot for reference.

I think we should change it to be "subdomain.domain.tld".

Bryan, Aaron, what do you think?
> I think we should change it to be "subdomain.domain.tld".

In this case, blog.bugzilla.com
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
Summary: AS Context menu titles leave out information (inconsistent with top sites) → AS Context menu page domain scheme (domain.tld) leave out information, is inconsistent with top sites
btw, ignore the debug lines in the screenshots please! :)
tracking-fennec: ? → +
Priority: -- → P2
Rank: 3
Spoke with bbell via vidyo:

For the top sites title & highlights domain title, we should be consistent and do "subdomain.domain".

For the context menu, it's okay to have more information: we should do "subdomain.domain.tld".
Flags: needinfo?(bbell)
Flags: needinfo?(abenson)
This is easy - let's knock it out.
Assignee: nobody → michael.l.comella
Iteration: --- → 1.29
Rank: 3
Priority: P2 → P1
Comment on attachment 8906133 [details]
Bug 1393577: Change highlight domain title to subdomain.domain.

https://reviewboard.mozilla.org/r/177874/#review182944

Nice job making this easy to change :P
Attachment #8906133 - Flags: review?(liuche) → review+
Comment on attachment 8906134 [details]
Bug 1393577: Change AS context menu title to subdomain.domain.tld.

https://reviewboard.mozilla.org/r/177876/#review182946
Attachment #8906134 - Flags: review?(liuche) → review+
Pushed by michael.l.comella@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/27b589b9c3f4
Change highlight domain title to subdomain.domain. r=liuche
https://hg.mozilla.org/integration/autoland/rev/1a510d80a28f
Change AS context menu title to subdomain.domain.tld. r=liuche
https://hg.mozilla.org/mozilla-central/rev/27b589b9c3f4
https://hg.mozilla.org/mozilla-central/rev/1a510d80a28f
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
You need to log in before you can comment on or make changes to this bug.