1393577 - AS Context menu page domain scheme (domain.tld) leave out information, is inconsistent with top sites

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, enhancement, P1)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot 1: top sites (blog.bugzilla)

For blog.bugzilla.com in top sites, we show "blog.bugzilla".

In the context menu, we show, "bugzilla.com", which feels like it's leaving something out and inconsistent with top sites' "subdomain.domain". See the attached screenshot for reference.

I think we should change it to be "subdomain.domain.tld".

Bryan, Aaron, what do you think?

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Screenshot 2: context menu (bugzilla.com)

> I think we should change it to be "subdomain.domain.tld".

In this case, blog.bugzilla.com

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

btw, ignore the debug lines in the screenshots please! :)

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Spoke with bbell via vidyo:

For the top sites title & highlights domain title, we should be consistent and do "subdomain.domain".

For the context menu, it's okay to have more information: we should do "subdomain.domain.tld".

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This is easy - let's knock it out.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1393577: Change highlight domain title to subdomain.domain.

We strip common subdomains from subdomain.domain because things like
"m.youtube" and "www.mozilla" look really bad.

Review commit: https://reviewboard.mozilla.org/r/177874/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177874/

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: Bug 1393577: Change AS context menu title to subdomain.domain.tld.

Unlike the previous changeset, we don't strip common subdomains because
"m.youtube.com" and "www.mozilla.org" can be informative and don't look bad
when you have a tld.

Review commit: https://reviewboard.mozilla.org/r/177876/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/177876/

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8906133 [details]
Bug 1393577: Change highlight domain title to subdomain.domain.

https://reviewboard.mozilla.org/r/177874/#review182944

Nice job making this easy to change :P

Comment 8

[Chenxia Liu [:liuche]]

Comment on attachment 8906134 [details]
Bug 1393577: Change AS context menu title to subdomain.domain.tld.

https://reviewboard.mozilla.org/r/177876/#review182946

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27b589b9c3f4
Change highlight domain title to subdomain.domain. r=liuche
https://hg.mozilla.org/integration/autoland/rev/1a510d80a28f
Change AS context menu title to subdomain.domain.tld. r=liuche

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/27b589b9c3f4
https://hg.mozilla.org/mozilla-central/rev/1a510d80a28f