Closed Bug 1393590 Opened 5 years ago Closed 5 years ago

[mach] Replace settings' gettext locale mechanism with a description attribute

Categories

(Firefox Build System :: Mach Core, enhancement)

57 Branch
enhancement
Not set
normal

Tracking

(firefox57 fixed)

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(1 file)

I've been wanting to add a bunch of settings to mach, but keep putting it off because it's such a pain to generate the locale strings. Let's just use a description field instead.
Comment on attachment 8901229 [details]
Bug 1393590 - [mach] Use description field for settings instead of gettext locales,

https://reviewboard.mozilla.org/r/172688/#review178246

Thank you for doing this.

As I was reading this, I wondered if it would be useful to declare options using functions. That way, you could use the docstring as the description string. But that's obviously follow-up fodder.
Attachment #8901229 - Flags: review?(gps) → review+
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40d1b97a874d
[mach] Use description field for settings instead of gettext locales, r=gps
https://hg.mozilla.org/mozilla-central/rev/40d1b97a874d
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.