1393636 - Report memory usage of Gecko style structs separately

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Nicholas Nethercote [inactive]]

We currently report each style structs memory usage separately for Stylo. heycam wants it for Gecko as well, for easier comparisons.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Reorder nsWindowSizes reporting

This patch just moves code around, so that the reporting is done in the same
order that the nsWindowSizes fields are declared. This makes it easier to see
whether anything has been missed.

(I'd like to use macros to generate this repetitive code instead of writing it
by hand, but that's a task for later.)

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Add "window-objects/dom/performance" memory report

Memory reporting was recently added for these DOM performance objects, but we
failed to report the "window-objects/" totals for the entire process. This
patch adds that.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Pass nsWindowSizes to more AddSizeOf*() functions

This is a purely non-functional plumbing change. Instead of passing a
SizeOfState and an nsStyleSizes a bunch of places, we pass an nsWindowSizes,
which contains both of them.

This is a necessary precursor for the next patch.

Comment 4

[Nicholas Nethercote [inactive]]

Attachment: (part 4) - Move ComputedValues measurements from nsStyleSizes to nsWindowSizes

Another plumbing-only change, which is a precursor for the next patch.
ComputedValues are a Servo-only thing, so in order to use nsStyleSizes for both
Gecko and Servo, the ComputedValues sizes must be moved out.

Comment 5

[Nicholas Nethercote [inactive]]

Attachment: (part 5) - Report memory usage of Gecko style structs separately

A lot of this involves copy-pasting the existing Servo style structs code.

Note that nsArenaSizes had to be moved after nsStyleSizes, because the former
now contains an instance of the latter.

Comment 6

[Cameron McCormack (:heycam)]

Comment on attachment 8901020 [details] [diff] [review]
(part 1) - Reorder nsWindowSizes reporting

Review of attachment 8901020 [details] [diff] [review]:
-----------------------------------------------------------------

Unfortunately Splinter (unlike mozreview) doesn't help to point out lines of code moved, so I'll just trust that these lines are just moved and not modified.

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8fa508b19f3aacb1857720aeebc692ace19ab52e
Bug 1393636 (part 1) - Reorder nsWindowSizes reporting. r=heycam.

https://hg.mozilla.org/integration/mozilla-inbound/rev/3ffbe000410322acc9075658188faf7722f31054
Bug 1393636 (part 2) - Add "window-objects/dom/performance" memory report. r=heycam.

https://hg.mozilla.org/integration/mozilla-inbound/rev/516d09433b8de10647358e634247abf35c59785f
Bug 1393636 (part 3) - Pass nsWindowSizes to more AddSizeOf*() functions. r=heycam.

https://hg.mozilla.org/integration/mozilla-inbound/rev/af9e67e05d3654a459c4d9bf6ca5dafe0baaea67
Bug 1393636 (part 4) - Move ComputedValues measurements from nsStyleSizes to nsWindowSizes. r=heycam.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfca0e591024c79bf6cf96bc3117d1c8a06c0b47
Bug 1393636 (part 5) - Report memory usage of Gecko style structs separately. r=heycam.

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8fa508b19f3a
https://hg.mozilla.org/mozilla-central/rev/3ffbe0004103
https://hg.mozilla.org/mozilla-central/rev/516d09433b8d
https://hg.mozilla.org/mozilla-central/rev/af9e67e05d36
https://hg.mozilla.org/mozilla-central/rev/bfca0e591024