run-task: strip microsecond

RESOLVED FIXED

Status

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: jonasfj, Assigned: jonasfj)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
microsecond timing probably doesn't have much use.
Let's strip it and reclaim some log margin...

Note: we could round it to two decimals, if people really want it.
(Assignee)

Updated

a year ago
Assignee: nobody → jopsen
Status: NEW → ASSIGNED
(Assignee)

Comment 1

a year ago
Fix here: https://hg.mozilla.org/try/rev/6ec968bbca0016c93be1dd524de78a9c5a9f19bc
And try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b164b63de4cc4dc76c0026e2e3d73f00ea2ff79

For some reason |hg push review| doesn't work... probably bad config on my end, I'll dig into that tomorrow...
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8901280 - Flags: review?(gps)

Comment 3

a year ago
mozreview-review
Comment on attachment 8901280 [details]
Bug 1393655 - Strip microsecond from run-task logs

https://reviewboard.mozilla.org/r/172732/#review178244

I agree that microsecond isn't that useful. But this change brings us down to second latency and that is too coarse. I'll accept a patch to reduce this to millisecond latency.
Attachment #8901280 - Flags: review?(gps) → review-
Comment hidden (mozreview-request)

Comment 5

a year ago
mozreview-review
Comment on attachment 8901280 [details]
Bug 1393655 - Strip microsecond from run-task logs

https://reviewboard.mozilla.org/r/172732/#review184126

I would prefer full millisecond resolution. But centisecond is probably good enough.
Attachment #8901280 - Flags: review?(gps) → review+
(Assignee)

Comment 6

a year ago
Then full millisecond you shall have :)

 - I don't know what I was thinking... centiseconds... tsk tsk...
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 8

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9c24bd90faa1
Strip microsecond from run-task logs r=gps
Keywords: checkin-needed
(Assignee)

Comment 9

a year ago
Thanks :)
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.