1393655 - run-task: strip microsecond

Status: RESOLVED FIXED

(Taskcluster :: General, enhancement)

Description

[Jonas Finnemann Jensen (:jonasfj)]

microsecond timing probably doesn't have much use.
Let's strip it and reclaim some log margin...

Note: we could round it to two decimals, if people really want it.

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

Fix here: https://hg.mozilla.org/try/rev/6ec968bbca0016c93be1dd524de78a9c5a9f19bc
And try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5b164b63de4cc4dc76c0026e2e3d73f00ea2ff79

For some reason |hg push review| doesn't work... probably bad config on my end, I'll dig into that tomorrow...

Comment 2

[Jonas Finnemann Jensen (:jonasfj)]

Attachment: Bug 1393655 - Strip microsecond from run-task logs

* Strip microsecond from log prefixes generated
    by run-task.

Review commit: https://reviewboard.mozilla.org/r/172732/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172732/

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 8901280 [details]
Bug 1393655 - Strip microsecond from run-task logs

https://reviewboard.mozilla.org/r/172732/#review178244

I agree that microsecond isn't that useful. But this change brings us down to second latency and that is too coarse. I'll accept a patch to reduce this to millisecond latency.

Comment 4

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8901280 [details]
Bug 1393655 - Strip microsecond from run-task logs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172732/diff/1-2/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8901280 [details]
Bug 1393655 - Strip microsecond from run-task logs

https://reviewboard.mozilla.org/r/172732/#review184126

I would prefer full millisecond resolution. But centisecond is probably good enough.

Comment 6

[Jonas Finnemann Jensen (:jonasfj)]

Then full millisecond you shall have :)

 - I don't know what I was thinking... centiseconds... tsk tsk...

Comment 7

[Jonas Finnemann Jensen (:jonasfj)]

Comment on attachment 8901280 [details]
Bug 1393655 - Strip microsecond from run-task logs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172732/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9c24bd90faa1
Strip microsecond from run-task logs r=gps

Comment 9

[Jonas Finnemann Jensen (:jonasfj)]

Thanks :)

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9c24bd90faa1