1393676 - test_ext_options_ui.html is going to permafail on Android x86 when Gecko 57 merges to Beta on 2017-09-20

Status: VERIFIED FIXED

(WebExtensions :: Android, defect, P1)

Description

[Ryan VanderMeulen [:RyanVM]]

[Tracking Requested - why for this release]: Permafailing test on the next merge day.

Android x86 only from the looks of it.

https://treeherder.mozilla.org/logviewer.html#?job_id=125745971&repo=try

INFO TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_options_ui.html | Test timed out.
INFO TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_options_ui.html | Extension left running at test shutdown

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1393676 - Fix intermittent timeout failures on options_ui Android tests.

Review commit: https://reviewboard.mozilla.org/r/172658/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172658/

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

I've tried to reproduce it locally (by pulling from the merge test linked above and building Fennec on Android x86 locally), and even if I'm not able to reproduce a permafail locally, I'm able to see it failing intermittently by running the test file using "./mach mochitest ... --run-until-failure".

From the debugging session that I've been doing locally, it seems that the timeout is related to a race between
the `BrowserApp.closeTab` calls used in the test to close the tabs and `BrowserApp.selectOrAddTab` (used in both the test and in `runtime.openOptionsPage` when open_in_tab is true): 

`BrowserApp.closeTab` sends a request to the Java side to remove the tab, but the actual tab object is removed from the "tab deck" only when BrowserApp receives the reply from the Java side, while `BrowserApp.selectOrAddTab` will try to select an existent tab from the "tabs deck" if it is still there (even if it is going to be removed soon as an effect of the BrowserApp.closeTab call).

It probably has an higher chance to happen on Android x86 because the emulator is way faster than the ARM one.

I'm attaching a patch which applies some changes to the options_ui test cases to avoid this kind of race conditions.

Comment 3

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8901192 [details]
Bug 1393676 - Fix intermittent timeout failures on options_ui Android tests.

https://reviewboard.mozilla.org/r/172658/#review178178

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34a4eebfa165
Fix intermittent timeout failures on options_ui Android tests. r=mixedpuppy

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/34a4eebfa165

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

This is fixed, no need to track it.