Should compute visibility when creating fallback data in layers-free mode

RESOLVED FIXED in Firefox 57

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: ethlin, Assigned: ethlin)

Tracking

(Blocks: 1 bug)

unspecified
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

8 months ago
For CreateWebRenderCommands(), we don't care the visible region. But for fallback path, the Paint() function may refer the variable that comes from ComputeVisibility(). So we should call ComputeVisibility() before painting.
(Assignee)

Comment 1

8 months ago
A related reftest is "layout/reftests/box-shadow/boxshadow-inner-basic.html".
Comment hidden (mozreview-request)

Comment 3

8 months ago
mozreview-review
Comment on attachment 8901078 [details]
Bug 1393706 - Compute display item's visibility when creating fallback data in layers-free mode.

https://reviewboard.mozilla.org/r/172576/#review177920

Can you add a comment at the call to ComputeVisibility about why it needs to be there and give an example of a DisplayItem and place that uses the values?
Attachment #8901078 - Flags: review+
Comment on attachment 8901078 [details]
Bug 1393706 - Compute display item's visibility when creating fallback data in layers-free mode.

Got r=jrmuizel
Attachment #8901078 - Flags: review?(bugmail)
(Assignee)

Comment 5

8 months ago
(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Comment on attachment 8901078 [details]
> Bug 1393706 - Compute display item's visibility when creating fallback data
> in layers-free mode.
> 
> https://reviewboard.mozilla.org/r/172576/#review177920
> 
> Can you add a comment at the call to ComputeVisibility about why it needs to
> be there and give an example of a DisplayItem and place that uses the values?

Okay, I will add a comment for the reason.
Comment hidden (mozreview-request)

Comment 7

8 months ago
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e8f739cba12
Compute display item's visibility when creating fallback data in layers-free mode. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/0e8f739cba12
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox57: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.