1393706 - Should compute visibility when creating fallback data in layers-free mode

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

For CreateWebRenderCommands(), we don't care the visible region. But for fallback path, the Paint() function may refer the variable that comes from ComputeVisibility(). So we should call ComputeVisibility() before painting.

Comment 1

[Ethan Lin[:ethlin]]

A related reftest is "layout/reftests/box-shadow/boxshadow-inner-basic.html".

Comment 2

[Ethan Lin[:ethlin]]

Attachment: Bug 1393706 - Compute display item's visibility when creating fallback data in layers-free mode.

Review commit: https://reviewboard.mozilla.org/r/172576/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/172576/

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8901078 [details]
Bug 1393706 - Compute display item's visibility when creating fallback data in layers-free mode.

https://reviewboard.mozilla.org/r/172576/#review177920

Can you add a comment at the call to ComputeVisibility about why it needs to be there and give an example of a DisplayItem and place that uses the values?

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8901078 [details]
Bug 1393706 - Compute display item's visibility when creating fallback data in layers-free mode.

Got r=jrmuizel

Comment 5

[Ethan Lin[:ethlin]]

(In reply to Jeff Muizelaar [:jrmuizel] from comment #3)
> Comment on attachment 8901078 [details]
> Bug 1393706 - Compute display item's visibility when creating fallback data
> in layers-free mode.
> 
> https://reviewboard.mozilla.org/r/172576/#review177920
> 
> Can you add a comment at the call to ComputeVisibility about why it needs to
> be there and give an example of a DisplayItem and place that uses the values?

Okay, I will add a comment for the reason.

Comment 6

[Ethan Lin[:ethlin]]

Comment on attachment 8901078 [details]
Bug 1393706 - Compute display item's visibility when creating fallback data in layers-free mode.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/172576/diff/1-2/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e8f739cba12
Compute display item's visibility when creating fallback data in layers-free mode. r=jrmuizel

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0e8f739cba12