1393756 - [Form Autofill] Complete the rest of mochitest test cases for credit card doorhanger

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement, P3)

Description

[Steve Chung [:steveck]]

We already add some mochitest in Bug #1371113, but there's still some features that need to be verified:
- With masterpassword case
- Never save credit card case since we still have some problem while waiting for menu list or something.

Comment 1

[Steve Chung [:steveck]]

Attachment: Bug 1393756 - Part 1: Add mochitest for credit card doorhanger never save option.

Review commit: https://reviewboard.mozilla.org/r/181680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/181680/

Comment 2

[Steve Chung [:steveck]]

Attachment: Bug 1393756 - Part 2: Add mochitest for credit card doorhanger saving with masterpassword.

Review commit: https://reviewboard.mozilla.org/r/182026/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/182026/

Comment 3

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8910183 [details]
Bug 1393756 - Part 1: Add mochitest for credit card doorhanger never save option.

https://reviewboard.mozilla.org/r/181680/#review188636

Comment 4

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8910587 [details]
Bug 1393756 - Part 2: Add mochitest for credit card doorhanger saving with masterpassword.

https://reviewboard.mozilla.org/r/182026/#review188652

::: browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js:126
(Diff revision 1)
> +      await TestUtils.topicObserved("formautofill-storage-changed");
> +    }
> +  );
> +
> +  let creditCards = await getCreditCards();
> +  is(creditCards.length, 2, "2 address in storage");

2 "credit cards" in storage

::: browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js:127
(Diff revision 1)
> +    }
> +  );
> +
> +  let creditCards = await getCreditCards();
> +  is(creditCards.length, 2, "2 address in storage");
> +  is(creditCards[1]["cc-name"], "User 0", "Verify the name field");

I suggest verifying masked number as well.

::: browser/extensions/formautofill/test/browser/browser_creditCard_doorhanger.js:161
(Diff revision 1)
> +    }
> +  );
> +
> +  await sleep(1000);
> +  let creditCards = await getCreditCards();
> +  is(creditCards.length, 2, "Still 2 address in storage");

Still 2 "credit cards" in storage

::: browser/extensions/formautofill/test/browser/head.js:86
(Diff revision 1)
>  
>  const MAIN_BUTTON = "button";
>  const SECONDARY_BUTTON = "secondaryButton";
>  const MENU_BUTTON = "menubutton";
>  
> +let masterPassword = {

I think you can use `resource://testing-common/LoginTestUtils.jsm` directly.

::: browser/extensions/formautofill/test/browser/head.js:124
(Diff revision 1)
> +  // Wait for master password dialog and cancel to close it.
> +  waitForDialog(enter) {

This comment needs to be updated according to `enter` parameter. Also, I would prefer to rename the function as it isn't just waiting.

Comment 5

[Steve Chung [:steveck]]

Comment on attachment 8910587 [details]
Bug 1393756 - Part 2: Add mochitest for credit card doorhanger saving with masterpassword.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182026/diff/1-2/

Comment 6

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8910587 [details]
Bug 1393756 - Part 2: Add mochitest for credit card doorhanger saving with masterpassword.

https://reviewboard.mozilla.org/r/182026/#review189686

Looks good.

::: browser/extensions/formautofill/test/browser/head.js:230
(Diff revision 2)
> -// Wait for master password dialog and cancel to close it.
> -function waitForMasterPasswordDialog() {
> +// Wait for master password dialog and
> +// - cancel to close it if password is not provided.
> +// - login with the password in LoginTestUtils.masterPassword

You need to explain what the "login" parameter does. e.g. 

```
Wait for the master password dialog to popup and enter the password to log in if "login" is "true" or dismiss it directly if otherwise.
```

Comment 7

[Steve Chung [:steveck]]

Comment on attachment 8910587 [details]
Bug 1393756 - Part 2: Add mochitest for credit card doorhanger saving with masterpassword.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/182026/diff/2-3/

Comment 8

[Steve Chung [:steveck]]

Thanks!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a98b2ce8a96
Part 1: Add mochitest for credit card doorhanger never save option. r=lchang
https://hg.mozilla.org/integration/autoland/rev/53670ed7793d
Part 2: Add mochitest for credit card doorhanger saving with masterpassword. r=lchang

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/7a98b2ce8a96
https://hg.mozilla.org/mozilla-central/rev/53670ed7793d